Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split libvcx, deprecate libvcx::api_c, libvcx-ios, libvcx-java #753

Closed
Patrik-Stas opened this issue Feb 14, 2023 · 1 comment
Closed

Split libvcx, deprecate libvcx::api_c, libvcx-ios, libvcx-java #753

Patrik-Stas opened this issue Feb 14, 2023 · 1 comment

Comments

@Patrik-Stas
Copy link
Contributor

Split the 2 modules of libvcx: api_c,api_vcx into 2 separate crates:

  • api_c -> libvcx

  • api_vcx -> libvcx_core

  • Deprecate (unless willing maintainers would be found) libvcx and ios and java wrapped built on top of it

Naming can be tweaked.

@Patrik-Stas
Copy link
Contributor Author

Patrik-Stas commented Feb 14, 2023

Additionally few more ideas, this can perhaps deserve its own issue, but for now just throwing it here:

  • We could do bit of reorg after that to clean up the root directory of the project. Instead of having
- libvcx
- libvcx_core
- wrappers

I'd suggest we have just 1 root directory libvcx where we can place all of these. Even wrappers, as they represent libvcx wrappers, built around the handles architecture.

  • Following this approach in UniFFI Proof of Concept #737 we could then create new top level directory
    unifii_vcx (or something like that) and place there the core unifii based wrapper alongside demos built on top of that.

  • And one more point: instead of having agents in root which contain both "libvcx" based agent and aries-vcx based agent, we could reorg them accordingly too (move libvcx based node agent under libvcx directory)

To conclude, something like this would be final result:

agents
   - aries-vcx-agent
libvcx
   - libvcx
   - libvcx_core
   - wrappers
       - vcx_napi_rs
       - ....
   - agents
      - vcxagenct_core
unifii_vcx
  - core
  - demos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant