Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract protocols crate #698

Closed
Patrik-Stas opened this issue Dec 17, 2022 · 1 comment
Closed

Extract protocols crate #698

Patrik-Stas opened this issue Dec 17, 2022 · 1 comment

Comments

@Patrik-Stas
Copy link
Contributor

Module aries-vcx/src/protocols/ should be a separate crate completely unaware of existence of ledger, wallet or particular credential types. Instead, these particular implementations should be injectable.

  • Important step toward enabling this has been done by George's modularization PR Modularize dependency on vdrtools/indy with option for indy-Vdr and Indy-Credx in place #648 which is essentially shielding off state machine code from particular implementations - for example function _create_credential in protocols/issuance/issuer/states/state_machine.rs calls anoncreds.issuer_create_credential(...), but the anoncreds object is just BaseAnonCreds trait interface.

It's worth of note that with current approach, the state machines are still aware of anoncreds implementation details, as the interfaces require passing quite specific information like tails_dir or rev_reg_id. So the current state machines are currently not generic enough to support different type of credentials, like LD or BBS, but I think that's fine for now.

@Patrik-Stas
Copy link
Contributor Author

Turns out to be duplicate of #113

@Patrik-Stas Patrik-Stas moved this to Done in aries-vcx Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant