From d91952340029754f23a92c83844916568cb48992 Mon Sep 17 00:00:00 2001 From: Patrik Stas Date: Thu, 16 Nov 2023 12:24:12 +0100 Subject: [PATCH] Fix lints Signed-off-by: Patrik Stas --- aries/agents/rust/mediator/src/aries_agent/mod.rs | 3 +-- aries/agents/rust/mediator/src/http_routes/mod.rs | 4 +--- aries/legacy/libvcx_core/src/api_vcx/api_global/wallet.rs | 2 +- aries/legacy/libvdrtools/src/lib.rs | 5 ++--- aries_vcx/tests/utils/scenarios/credential_issuance.rs | 2 +- 5 files changed, 6 insertions(+), 10 deletions(-) diff --git a/aries/agents/rust/mediator/src/aries_agent/mod.rs b/aries/agents/rust/mediator/src/aries_agent/mod.rs index c4db4c94f2..7132f6ad8c 100644 --- a/aries/agents/rust/mediator/src/aries_agent/mod.rs +++ b/aries/agents/rust/mediator/src/aries_agent/mod.rs @@ -114,8 +114,7 @@ impl Agent { if let Some(service) = &self.service { let invitation = OutOfBandSender::create() .append_service(&OobService::AriesService(service.clone())) - .oob - .clone(); + .oob; Ok(invitation) } else { Err("No service to create invite for".to_owned()) diff --git a/aries/agents/rust/mediator/src/http_routes/mod.rs b/aries/agents/rust/mediator/src/http_routes/mod.rs index 3998f64afa..2c5c3d21a8 100644 --- a/aries/agents/rust/mediator/src/http_routes/mod.rs +++ b/aries/agents/rust/mediator/src/http_routes/mod.rs @@ -58,9 +58,7 @@ pub async fn handle_didcomm( State(agent): State>, didcomm_msg: Bytes, ) -> Result, String> { - didcomm_handlers::handle_aries(State(agent), didcomm_msg) - .await - .map_err(|e| e.to_string()) + didcomm_handlers::handle_aries(State(agent), didcomm_msg).await } pub async fn readme() -> Html { diff --git a/aries/legacy/libvcx_core/src/api_vcx/api_global/wallet.rs b/aries/legacy/libvcx_core/src/api_vcx/api_global/wallet.rs index ab69f83e04..c5fad7af17 100644 --- a/aries/legacy/libvcx_core/src/api_vcx/api_global/wallet.rs +++ b/aries/legacy/libvcx_core/src/api_vcx/api_global/wallet.rs @@ -55,7 +55,7 @@ fn setup_global_wallet(wallet_handle: WalletHandle) -> LibvcxResult<()> { // new way let base_wallet_impl = build_component_base_wallet(wallet_handle); let mut b_wallet = GLOBAL_BASE_WALLET.write()?; - *b_wallet = Some(base_wallet_impl.clone()); + *b_wallet = Some(base_wallet_impl); // anoncreds let base_anoncreds_impl = Arc::new(IndyCredxAnonCreds); let mut b_anoncreds = GLOBAL_BASE_ANONCREDS.write()?; diff --git a/aries/legacy/libvdrtools/src/lib.rs b/aries/legacy/libvdrtools/src/lib.rs index 3221fee2a3..d8e22c6bb2 100644 --- a/aries/legacy/libvdrtools/src/lib.rs +++ b/aries/legacy/libvdrtools/src/lib.rs @@ -86,9 +86,8 @@ impl Locator { let did_controller = DidController::new(wallet_service.clone(), crypto_service.clone()); - let wallet_controller = - WalletController::new(wallet_service.clone(), crypto_service.clone()); - let non_secret_controller = NonSecretsController::new(wallet_service.clone()); + let wallet_controller = WalletController::new(wallet_service.clone(), crypto_service); + let non_secret_controller = NonSecretsController::new(wallet_service); let res = Locator { crypto_controller, diff --git a/aries_vcx/tests/utils/scenarios/credential_issuance.rs b/aries_vcx/tests/utils/scenarios/credential_issuance.rs index 78d4c2f7d8..376f184933 100644 --- a/aries_vcx/tests/utils/scenarios/credential_issuance.rs +++ b/aries_vcx/tests/utils/scenarios/credential_issuance.rs @@ -84,7 +84,7 @@ pub fn create_holder_from_proposal(proposal: ProposeCredentialV1) -> Holder { pub fn create_issuer_from_proposal(proposal: ProposeCredentialV1) -> Issuer { let issuer = Issuer::create_from_proposal("TEST_CREDENTIAL", &proposal).unwrap(); assert_eq!(IssuerState::ProposalReceived, issuer.get_state()); - assert_eq!(proposal.clone(), issuer.get_proposal().unwrap()); + assert_eq!(proposal, issuer.get_proposal().unwrap()); issuer }