refactor: Refactor negative test cases in refund.test to use Jest assertions #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.60 to 0.10.66. - [Release notes](https://github.com/sfackler/rust-openssl/releases) - [Commits](sfackler/rust-openssl@openssl-v0.10.60...openssl-v0.10.66) --- updated-dependencies: - dependency-name: openssl dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
…age pull Primary Changes ---------------- 1. Migrated all the xdai connector tests to besu ledger images that is being pulled from ghcr Fixes hyperledger-cacti#3413 Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com> Signed-off-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
Signed-off-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
95f58f9 to
a892f08
Compare
outSH
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Thanks for this contribution! Please read our contributing guide (https://github.com/hyperledger/cacti/blob/main/CONTRIBUTING.md) and fix the PR, for instance:
- Rebase with main and squash your changes into single commit, make the commit descriptive and aligned with PR title / content.
- Fix the title, use the one peter proposed in related issue (test(plugin-htlc-coordinator-besu): use Jest error assert in refund.test #3457).
- Read the document I've attached and fix any other issues you'll find :)
| @@ -141,7 +141,7 @@ | |||
| "@types/benchmark": "2.1.5", | |||
| "@types/debug": "4.1.12", | |||
| "@types/fs-extra": "11.0.4", | |||
| "@types/jest": "29.5.3", | |||
| "@types/jest": "^29.5.12", | |||
There was a problem hiding this comment.
Please use pinned version of dependencies (i.e. 29.5.12, without ^
|
Moved to #3464 |
|
@Deepakchowdavarapu Please do not open multiple PRs in the future and read the contributing.md document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Negative Test Cases in refund.test.ts to Use Jest Assertions
Replaced try-catch blocks with Jest’s .rejects matcher for error scenarios
in refund.test.ts. Updated test cases to use .toMatch and .toThrow for
error assertions, improving test readability and maintainability.
Test results remain consistent, and all assertions now leverage Jest’s
built-in methods.
BREAKING CHANGE: None
Signed-off-by: Deepakchowdavarapu deepak.23bcs10092@ms.sst.scaler.com