-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(plugin-htlc-coordinator-besu): use Jest error assert in refund.test #3457
Comments
I would like to work on this issue. |
@Deepakchowdavarapu You got it! Thank you in advance for the contribution! |
@petermetz please review my work #3460 |
@Deepakchowdavarapu Please see the reviews posted on the pull request! Let me know if you need any help with any of it and I also wanted to let you know about the daily pair programming sessions that we host which are open for everyone on the internet to come in and ask questions about Cacti: https://wiki.hyperledger.org/display/cactus/Daily+Pair+Programming+Calls |
Reassigning this issue to @adrianbatuto due to inactivity |
Primary Changes ---------------- 1. Refactored try-catch scenario in refund.test.ts Fixes hyperledger-cacti#3457 Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
Primary Changes ---------------- 1. Refactored try-catch scenario in refund.test.ts Fixes hyperledger-cacti#3457 Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
Primary Changes ---------------- 1. Refactored try-catch scenario in refund.test.ts Fixes hyperledger-cacti#3457 Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
Description
Refactor the negative test case exception assertions so that they do not use try-catch blocks but instead declare the requirements through Jest's (and
jest-extended
's) own API.The parent issue with a much more detailed explanation of what's needed and code examples on how to do it:
Parent Issue: #3455
The test case to work on in the scope of this issue:
extensions/cactus-plugin-htlc-coordinator-besu/src/test/typescript/integration/plugin-htlc-coordinator/refund.test.ts
The way to run the test case:
yarn jest extensions/cactus-plugin-htlc-coordinator-besu/src/test/typescript/integration/plugin-htlc-coordinator/refund.test.ts
Acceptance Criteria
The text was updated successfully, but these errors were encountered: