Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): clean up typescript compiler dependency declarations #2532

Closed
petermetz opened this issue Jul 3, 2023 · 0 comments · Fixed by #2566
Closed

chore(deps): clean up typescript compiler dependency declarations #2532

petermetz opened this issue Jul 3, 2023 · 0 comments · Fixed by #2566
Assignees
@petermetz
Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have P4 Priority 4: Low Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.

Comments

@petermetz
Copy link
Contributor

We have declared 27 times so far the typescript compiler dependency in the project
throughout all the package.json files, but we only need it once, in the root,
to compile the typescript code of the monorepo.

Acceptance criteria:

  1. Get rid of all but one instance of it.
  2. Make sure that every org's maintainers approve not just the minimum 2 because this affects the entire codebase and could cause annoying breakages in the build and/or test cases, examples, tutorials, etc.
  3. For cases where we do have a justification for keeping around another dependency declration of it, list each and every case and why the decision was made to keep it around
    3.1. If the reason for keeping it around is because something breaks then include the exact error messages generated and how to reproduce them exactly from scratch as well instead of just saying "build is breaking without it" or other not-so-helpful messaging.
@petermetz petermetz added dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have P4 Priority 4: Low Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. labels Jul 3, 2023
@petermetz petermetz self-assigned this Jul 3, 2023
petermetz added a commit to petermetz/cacti that referenced this issue Jul 24, 2023
@petermetz
chore(deps): clean up typescript compiler dependency declarations
6ff0b3c 
Pinned all of the versions to 4.9.5 in all of the packages.

Fixes hyperledger-cacti#2532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 24, 2023
@petermetz
chore(deps): clean up typescript compiler dependency declarations
91bb97f 
Pinned all of the versions to 4.9.5 in all of the packages.

Fixes hyperledger-cacti#2532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This was referenced Jul 24, 2023
Merged
Closed
petermetz added a commit to petermetz/cacti that referenced this issue Aug 4, 2023
@petermetz
chore(deps): clean up typescript compiler dependency declarations
20b14f4 
Pinned all of the versions to 4.9.5 in all of the packages.

Fixes hyperledger-cacti#2532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Aug 4, 2023
@petermetz
chore(deps): clean up typescript compiler dependency declarations
d6cea3e 
Pinned all of the versions to 4.9.5 in all of the packages.

Fixes #2532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@petermetz @sandeepnRES
chore(deps): clean up typescript compiler dependency declarations
2ed9894 
Pinned all of the versions to 4.9.5 in all of the packages.

Fixes hyperledger-cacti#2532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have P4 Priority 4: Low Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): clean up typescript compiler dependency declarations petermetz/cacti
1 participant
@petermetz