Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ci): only publish artifacts on git version tags of main #2360

Closed
petermetz opened this issue Mar 31, 2023 · 2 comments · Fixed by #3278
Closed

perf(ci): only publish artifacts on git version tags of main #2360

petermetz opened this issue Mar 31, 2023 · 2 comments · Fixed by #3278
Assignees
@raynatopedrajeta
Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. SPIKE Exploratory work to better scope additional effort

Comments

@petermetz
Copy link
Contributor

Description

As a maintainer and/or contributor I want to have fast CI cycles so that I'm more productive and the community as a whole is growing faster because the contributions can be accepted at a rapid pace instead of the CI bogging everybody down.

Right now we have a lot of publishing tasks that take up resources (mostly) needlessly because they auto-publish artifacts such as container images and JVM API clients on every merged commit.
This has the negative effect of slowing the CI down overall and also the other negative effect that we are risking hitting limitations on the free tiers that we are using (limits where the number of versions must stay below a certain number for npm packages or container images for example).

One example of this auto-publishing is the kotlin [1] packages and all the other **-publish.yaml files that we have for the container images.

[1] .github/workflows/ghpkg-all-kotlin-api-clients-publish.yaml

Acceptance Criteria

  1. Go through every single .yaml file and produce a list of them which are currently doing auto-publishing on every commit to main
  2. Refactor the list of yaml's obtained in step 1 so that artifact publishing only happens on git tags.
  3. Make sure that the refactor happens in a way that the container image builds are still being tested as part of every PR.
@petermetz petermetz added good-first-issue Good for newcomers SPIKE Exploratory work to better scope additional effort dependencies Pull requests that update a dependency file Developer_Experience Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-400-expert P2 Priority 2: High labels Mar 31, 2023
@petermetz petermetz self-assigned this Mar 31, 2023
@petermetz petermetz mentioned this issue Jul 24, 2023
Closed
@raynatopedrajeta
Copy link
Contributor

Hello Team,

I was assigned on this task and will start to work on this as of today.

Thanks!

@petermetz
Copy link
Contributor Author

@raynatopedrajeta Got it, thank you!

raynatopedrajeta added a commit to raynatopedrajeta/cacti that referenced this issue May 22, 2024
@raynatopedrajeta
perf(ci): only publish artifacts on git version tags of main
a3a4972 
Primary Changes
----------------
1. Remove auto publishing of container images in all **publish.yaml
   upon push and maintain automation runs during pull requests

Fixes hyperledger-cacti#2360

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
@raynatopedrajeta raynatopedrajeta mentioned this issue May 22, 2024
Merged
5 tasks
@jagpreetsinghsasan jagpreetsinghsasan moved this from In Progress to In review in Cacti_Scrum_Project_v2_Release May 22, 2024
raynatopedrajeta added a commit to raynatopedrajeta/cacti that referenced this issue May 24, 2024
@raynatopedrajeta
perf(ci): only publish artifacts on git version tags of main
e2746f4 
Primary Changes
----------------
1. Remove auto publishing of container images in all **publish.yaml
   upon push and maintain automation runs during pull requests

Fixes hyperledger-cacti#2360

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
raynatopedrajeta added a commit to raynatopedrajeta/cacti that referenced this issue May 24, 2024
@raynatopedrajeta
perf(ci): only publish artifacts on git version tags of main
408277a 
Primary Changes
----------------
1. Remove auto publishing of container images in all **publish.yaml
   upon push and maintain automation runs during pull requests

Fixes hyperledger-cacti#2360

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
raynatopedrajeta added a commit to raynatopedrajeta/cacti that referenced this issue Jun 28, 2024
@raynatopedrajeta
perf(ci): only publish artifacts on git version tags of main
2f99830 
Primary Changes
----------------
1. Remove auto publishing of container images in all **publish.yaml
   upon push and maintain automation runs during pull requests

Fixes hyperledger-cacti#2360

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
raynatopedrajeta added a commit to raynatopedrajeta/cacti that referenced this issue Jul 1, 2024
@raynatopedrajeta
perf(ci): only publish artifacts on git version tags of main
0de9aee 
Primary Changes
----------------
1. Remove auto publishing of container images in all **publish.yaml
   upon push and maintain automation runs during pull requests

Fixes hyperledger-cacti#2360

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
raynatopedrajeta added a commit to raynatopedrajeta/cacti that referenced this issue Jul 1, 2024
@raynatopedrajeta
perf(ci): only publish artifacts on git version tags of main
e73103d 
Primary Changes
----------------
1. Remove auto publishing of container images in all **publish.yaml
   upon push and maintain automation runs during pull requests

Fixes hyperledger-cacti#2360

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
@github-project-automation github-project-automation bot moved this from In review to Done in Cacti_Scrum_Project_v2_Release Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raynatopedrajeta raynatopedrajeta

Labels
dependencies Pull requests that update a dependency file Developer_Experience good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. SPIKE Exploratory work to better scope additional effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(ci): only publish artifacts on git version tags of main raynatopedrajeta/cacti
2 participants
@petermetz @raynatopedrajeta