Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combox search should have type="search" #1184

Closed
srsgores opened this issue Feb 16, 2025 · 4 comments
Closed

combox search should have type="search" #1184

srsgores opened this issue Feb 16, 2025 · 4 comments
Labels
triage A maintainer needs to review this issue and label it appropriately

Comments

@srsgores
Copy link

Describe the bug

It looks like the input component supports type as a prop, so let's add the line here:

type="search"

Reproduction

N/A

Logs

System Info

N/A

Severity

annoyance

@srsgores srsgores added the triage A maintainer needs to review this issue and label it appropriately label Feb 16, 2025
@huntabyte
Copy link
Owner

You can add type="search" yourself by passing it to the Combobox.Input

<Combobox.Input type="search" />

@srsgores
Copy link
Author

But it should be the default, no?

@huntabyte
Copy link
Owner

huntabyte commented Feb 16, 2025

In my opinion, no. It already has an aria-role="combobox", and the WAI-ARIA examples don't apply type="search" either.

But the type is exposed for you to ultimately decide what makes sense for your project!

@srsgores
Copy link
Author

OK, fair. Thanks for clarifying 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage A maintainer needs to review this issue and label it appropriately
Projects
None yet
Development

No branches or pull requests

2 participants