Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-consider setting testVersion value by default #191

Closed
mikeselander opened this issue Apr 7, 2020 · 2 comments · Fixed by #198
Closed

Re-consider setting testVersion value by default #191

mikeselander opened this issue Apr 7, 2020 · 2 comments · Fixed by #198
Labels
phpcs

Comments

@mikeselander
Copy link
Contributor

mikeselander commented Apr 7, 2020 •
edited
Loading

In #187 (comment) it was identified that we should likely not be setting the testVersion value by default as it cannot be updated.

The <config name="testVersion" value="7.1-" /> should also be project based as it is near impossible to overrule otherwise.

We should look at removing this for 1.0.0 with the other ruleset-default breaking changes.
@ocean90
Copy link

ocean90 commented Apr 7, 2020

Related upstream issue: squizlabs/PHP_CodeSniffer#2197

@kadamwhite
Copy link
Contributor

Cross-referencing #186, and this suggests that we remove the minimum in our base HM standards (as it cannot easily be overridden).

@kadamwhite kadamwhite mentioned this issue May 19, 2020
Closed
@mikeselander mikeselander mentioned this issue May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
phpcs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Final PHPCS settings humanmade/coding-standards
3 participants
@kadamwhite @ocean90 @mikeselander