Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSpaceAfterCloseParenthesis is (currently) inconsistent. #108

Closed
dac514 opened this issue Dec 4, 2018 · 1 comment · Fixed by #82
Closed

NoSpaceAfterCloseParenthesis is (currently) inconsistent. #108

dac514 opened this issue Dec 4, 2018 · 1 comment · Fixed by #82
Assignees

Comments

@dac514
Copy link
Contributor

dac514 commented Dec 4, 2018

The WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterCloseParenthesis rule is (currently) inconsistent.

I get:

Space between opening control structure and closing parenthesis is required
(WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterCloseParenthesis)

For:

function test2( array $foo ): \Generator {
    yield 1;
}

But no complaints for the exact same code without a function parameter:

function test1(): \Generator {
    yield 1;
}

It might be fixed upstream?

See: WordPress/WordPress-Coding-Standards#547 (comment)

@mikeselander
Copy link
Contributor

This should be fixed via #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants