From 921c994a37a7b15e4018045b66914f8a9c500d56 Mon Sep 17 00:00:00 2001 From: Wauplin Date: Fri, 24 May 2024 11:34:57 +0200 Subject: [PATCH 1/3] Fix resume_download future warning --- src/transformers/configuration_utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/transformers/configuration_utils.py b/src/transformers/configuration_utils.py index b3d76aff9c65..4231338ec408 100755 --- a/src/transformers/configuration_utils.py +++ b/src/transformers/configuration_utils.py @@ -647,8 +647,8 @@ def _get_config_dict( cls, pretrained_model_name_or_path: Union[str, os.PathLike], **kwargs ) -> Tuple[Dict[str, Any], Dict[str, Any]]: cache_dir = kwargs.pop("cache_dir", None) - force_download = kwargs.pop("force_download", False) - resume_download = kwargs.pop("resume_download", False) + force_download = kwargs.pop("force_download", None) + resume_download = kwargs.pop("resume_download", None) proxies = kwargs.pop("proxies", None) token = kwargs.pop("token", None) local_files_only = kwargs.pop("local_files_only", False) From f34686b2585d56607c65477a75e6d9a0dbd339e9 Mon Sep 17 00:00:00 2001 From: Wauplin Date: Fri, 24 May 2024 11:44:29 +0200 Subject: [PATCH 2/3] better like this --- src/transformers/configuration_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/transformers/configuration_utils.py b/src/transformers/configuration_utils.py index 4231338ec408..5a40832b3468 100755 --- a/src/transformers/configuration_utils.py +++ b/src/transformers/configuration_utils.py @@ -647,7 +647,7 @@ def _get_config_dict( cls, pretrained_model_name_or_path: Union[str, os.PathLike], **kwargs ) -> Tuple[Dict[str, Any], Dict[str, Any]]: cache_dir = kwargs.pop("cache_dir", None) - force_download = kwargs.pop("force_download", None) + force_download = kwargs.pop("force_download", False) resume_download = kwargs.pop("resume_download", None) proxies = kwargs.pop("proxies", None) token = kwargs.pop("token", None) From 6921a7f5fc02915c8761352e8bd0254c8328b85a Mon Sep 17 00:00:00 2001 From: Wauplin Date: Fri, 24 May 2024 11:57:03 +0200 Subject: [PATCH 3/3] Add regression test --- tests/test_configuration_utils.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/test_configuration_utils.py b/tests/test_configuration_utils.py index 9b1c6c25b31e..a5322a176ec0 100644 --- a/tests/test_configuration_utils.py +++ b/tests/test_configuration_utils.py @@ -20,6 +20,7 @@ import tempfile import unittest import unittest.mock as mock +import warnings from pathlib import Path from huggingface_hub import HfFolder, delete_repo @@ -306,3 +307,10 @@ def test_has_non_default_generation_parameters(self): self.assertTrue(config._has_non_default_generation_parameters()) config = BertConfig(min_length=0) # `min_length = 0` is a default generation kwarg self.assertFalse(config._has_non_default_generation_parameters()) + + def test_loading_config_do_not_raise_future_warnings(self): + """Regression test for https://github.com/huggingface/transformers/issues/31002.""" + # Loading config should not raise a FutureWarning. It was the case before. + with warnings.catch_warnings(): + warnings.simplefilter("error") + PretrainedConfig.from_pretrained("bert-base-uncased")