From 0afe4c26e024b9111b231913ffe8e751705a8245 Mon Sep 17 00:00:00 2001 From: mizoru Date: Tue, 30 Apr 2024 20:41:01 +0300 Subject: [PATCH] Fix WhisperGenerationMixin._set_return_timestamps for return_timestamps=None When WhisperForConditionalGeneration.generate is called with return_timestamps=None and return_timestamps=True in generation_config WhisperGenerationMixin._set_return_timestamps replaces the value in the config with None, now set to check return_timestamps is not None --- src/transformers/models/whisper/generation_whisper.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/transformers/models/whisper/generation_whisper.py b/src/transformers/models/whisper/generation_whisper.py index b3865140f24e..42457ff8669c 100644 --- a/src/transformers/models/whisper/generation_whisper.py +++ b/src/transformers/models/whisper/generation_whisper.py @@ -1042,8 +1042,8 @@ def _set_return_timestamps(return_timestamps, is_shortform, generation_config): "Make sure to initialize the generation config with the correct attributes that are needed such as `no_timestamps_token_id`. " "For more details on how to generate the approtiate config, refer to https://github.com/huggingface/transformers/issues/21878#issuecomment-1451902363" ) - - generation_config.return_timestamps = return_timestamps + if return_timestamps is not None: + generation_config.return_timestamps = return_timestamps @staticmethod def _set_language_and_task(language, task, is_multilingual, generation_config):