Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding num_proc to load_dataset #26326

Merged
merged 4 commits into from
Sep 22, 2023
Merged

feat: adding num_proc to load_dataset #26326

merged 4 commits into from
Sep 22, 2023

Conversation

pphuc25
Copy link
Contributor

@pphuc25 pphuc25 commented Sep 21, 2023

What does this PR do?

As the demand for LLM models continues to grow, the size of the data being downloaded can slow down the process. To address this issue, I've submitted a PR to incorporate the "num_proc" feature into the "load_dataset" function, making data loading faster and more efficient.

I would like cc @sanchit-gandhi to review my PR.

Copy link
Contributor

@sanchit-gandhi sanchit-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks @pphuc25 for updating these scripts! We'll see a nice speed-up loading any sharded datasets.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pphuc25

@LysandreJik LysandreJik merged commit 910faa3 into huggingface:main Sep 22, 2023
@pphuc25 pphuc25 deleted the add_num_proc branch September 22, 2023 17:39
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* feat: adding num_proc to load_dataset

* feat: add add_num_proc for run_mlm_flax

* feat: add num_proc for bart and t5

* chorse: remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants