From db34665e244ff3fb883f86aae4d1726d12769b75 Mon Sep 17 00:00:00 2001 From: Lysandre Date: Wed, 6 Sep 2023 07:02:52 -0400 Subject: [PATCH 1/2] Fix revision propagation --- src/transformers/models/auto/configuration_auto.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/transformers/models/auto/configuration_auto.py b/src/transformers/models/auto/configuration_auto.py index cf93951c15e0..77c3afccdda0 100755 --- a/src/transformers/models/auto/configuration_auto.py +++ b/src/transformers/models/auto/configuration_auto.py @@ -1019,10 +1019,9 @@ def from_pretrained(cls, pretrained_model_name_or_path, **kwargs): revision = kwargs.pop("revision", None) revision = sanitize_code_revision(pretrained_model_name_or_path, revision, trust_remote_code) + kwargs["revision"] = revision - config_dict, unused_kwargs = PretrainedConfig.get_config_dict( - pretrained_model_name_or_path, revision=revision, **kwargs - ) + config_dict, unused_kwargs = PretrainedConfig.get_config_dict(pretrained_model_name_or_path, **kwargs) has_remote_code = "auto_map" in config_dict and "AutoConfig" in config_dict["auto_map"] has_local_code = "model_type" in config_dict and config_dict["model_type"] in CONFIG_MAPPING trust_remote_code = resolve_trust_remote_code( From 32359d8c780113d01ab54c8924043c714e98d4d5 Mon Sep 17 00:00:00 2001 From: Lysandre Date: Wed, 6 Sep 2023 07:04:20 -0400 Subject: [PATCH 2/2] Cleaner --- src/transformers/models/auto/configuration_auto.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/transformers/models/auto/configuration_auto.py b/src/transformers/models/auto/configuration_auto.py index 77c3afccdda0..4fd125f88ba3 100755 --- a/src/transformers/models/auto/configuration_auto.py +++ b/src/transformers/models/auto/configuration_auto.py @@ -1016,10 +1016,9 @@ def from_pretrained(cls, pretrained_model_name_or_path, **kwargs): kwargs["name_or_path"] = pretrained_model_name_or_path trust_remote_code = kwargs.pop("trust_remote_code", None) code_revision = kwargs.pop("code_revision", None) - revision = kwargs.pop("revision", None) - revision = sanitize_code_revision(pretrained_model_name_or_path, revision, trust_remote_code) - kwargs["revision"] = revision + revision = kwargs.pop("revision", None) + kwargs["revision"] = sanitize_code_revision(pretrained_model_name_or_path, revision, trust_remote_code) config_dict, unused_kwargs = PretrainedConfig.get_config_dict(pretrained_model_name_or_path, **kwargs) has_remote_code = "auto_map" in config_dict and "AutoConfig" in config_dict["auto_map"]