Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokenizer][bug] LLAVA 1.6 tokenizer problem #31901

Closed
4 tasks
lanking520 opened this issue Jul 11, 2024 · 4 comments
Closed
4 tasks

[Tokenizer][bug] LLAVA 1.6 tokenizer problem #31901

lanking520 opened this issue Jul 11, 2024 · 4 comments

Comments

@lanking520
Copy link

System Info

Any OS system that can run transformers

related issue: vllm-project/vllm#6224

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

transformers (4.42.3) and got the issue

from transformers import AutoTokenizer

tokenizer = AutoTokenizer.from_pretrained("llava-hf/llava-v1.6-34b-hf")
print(tokenizer.encode("<image>"))

print(tokenizer.vocab_size)

output

[64003]
64000

Can confirm transformers (4.40.1) does not have this issue

[64000]
64000

Expected behavior

It is supposed to be the same?

[64000]
64000
@DarkLight1337
Copy link

After trying this code on a few different versions, it looks like this got changed between 4.41.2 and 4.42.0.

@DarkLight1337
Copy link

DarkLight1337 commented Jul 11, 2024

Also, this issue only occurs for llava-hf/llava-v1.6-34b-hf. It works fine for llava-hf/llava-v1.6-mistral-7b-hf and llava-hf/llava-v1.6-vicuna-7b-hf.

Update: I think this is the same issue as #31713.

@zucchini-nlp
Copy link
Member

Answered in #31713 (comment)

@zucchini-nlp
Copy link
Member

Closing because #31902 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants