Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitsAndBytesConfig missing a validation #31124

Closed
1 of 4 tasks
hotab opened this issue May 29, 2024 · 0 comments · Fixed by #31135
Closed
1 of 4 tasks

BitsAndBytesConfig missing a validation #31124

hotab opened this issue May 29, 2024 · 0 comments · Fixed by #31135

Comments

@hotab
Copy link

hotab commented May 29, 2024

System Info

  • transformers version: 4.41.1
  • Platform: Windows-11-10.0.22631-SP0
  • Python version: 3.12.1
  • Huggingface_hub version: 0.23.2
  • Safetensors version: 0.4.3
  • Accelerate version: 0.30.1
  • Accelerate config: not found
  • PyTorch version (GPU?): 2.3.0+cu121 (True)
  • Tensorflow version (GPU?): not installed (NA)
  • Flax version (CPU?/GPU?/TPU?): not installed (NA)
  • Jax version: not installed
  • JaxLib version: not installed
  • Using GPU in script?: Yes
  • Using distributed or parallel set-up in script?: No

Who can help?

@SunMarc and @younesbelkada

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

from transformers import BitsAndBytesConfig
cfg = BitsAndBytesConfig(
    load_in_4bit=True,
    bnb_4bit_quant_storage='add'
)

Will not fail with a validation error and will just continue as-is

Expected behavior

Failing with a ValueError, same as bnb_4bit_compute_dtype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant