Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a subset in test fetcher if on main branch #29683

Closed
ydshieh opened this issue Mar 15, 2024 · 1 comment · Fixed by #29710
Closed

Don't use a subset in test fetcher if on main branch #29683

ydshieh opened this issue Mar 15, 2024 · 1 comment · Fixed by #29710
Assignees

Comments

@ydshieh
Copy link
Collaborator

ydshieh commented Mar 15, 2024

Feature request

Don't select a subset from the detected tests to run when they are many - if we are on the main branch.
This could detect any issue as early as at the merge time, not at the nightly run.

This is implemented in #28816 / #29673, but reverted in #29682 as we have

/bin/bash: line 25: /usr/bin/jq: Argument list too long
Exited with code exit status 126

as there are too many models and the arguments to pytest is too long.

We should find a way to overcome this in order to achieve our goal.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 16, 2024

Fixed in #29710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant