-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure OpenAI support #276
Comments
Hey that's a much better version! Thanks a lot for proposing this implementation: this would work, please go ahead and open a PR 🚀 |
Will do, thanks! |
@vladiliescu just wanted to say that this worked seamlessly for me, thank you! |
Great to hear this @matthewcarbone ! |
Closing this since the PR is merged, thank you @vladiliescu ! |
Perfect, thank you as well @aymeric-roucher ! |
I'd very much love to have native Azure OpenAI support for smolagents.
I understand that writing it is easy, but you may not want the burden of maintaining it indefinitely and you're trying to keep the surface area smol until the featureset becomes more complete and things are fleshed out. I've seen PR #161 .
I'd like to propose a simpler approach. Since smolagents already has an OpenAIServerModel implementation, this means we can subclass it and get all its current and future functionality for free, all we need to do is replace the openai client with the Azure flavor. So the burden for maintaining this class in the future is dramatically decreased.
Would the implementation beow be acceptable for you guys? If yes, I can send a PR. If not, I understand the reasons :).
The text was updated successfully, but these errors were encountered: