Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom IOBinding to IOBindingHelper #571

Merged
merged 4 commits into from
Dec 12, 2022
Merged

Conversation

JingyaHuang
Copy link
Contributor

What does this PR do?

Move the prepare_io_binding function from ORTModelForCustomTasks to IOBindingHelper as this could be helpful and reusable for other ORT models, namely the ongoing ORTModelForSemanticSegmentation(#539).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 9, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: fxmarty <9808326+fxmarty@users.noreply.github.com>
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JingyaHuang and others added 2 commits December 12, 2022 11:52
Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
@JingyaHuang JingyaHuang merged commit d7c8f3d into main Dec 12, 2022
@JingyaHuang JingyaHuang deleted the move-dynamic-iobinding branch December 12, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants