Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving external data for large ONNX models #255

Closed
wants to merge 15 commits into from
+51 −9
Closed

Saving external data for large ONNX models #255

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
031c70e
attempt at fixing saving onnx model with external data
NouamaneTazi Jul 1, 2022
6fec76f
styling
NouamaneTazi Jul 1, 2022
7c59c2e
fix: `cache_dir` wasn't used when loading from transformers
NouamaneTazi Jul 2, 2022
387fe6c
separate onnx_cache_dir argument from model's cache_dir
NouamaneTazi Jul 2, 2022
cce8e90
we can now load large ONNX models by specifying external's data direc…
NouamaneTazi Jul 2, 2022
5902565
Merge branch 'main' of https://github.com/huggingface/optimum into pr…
NouamaneTazi Dec 7, 2022
845f788
Fix saving external data for large models (seq2seq)
NouamaneTazi Dec 7, 2022
1f2687f
fix saving external data for all ORT models
NouamaneTazi Dec 7, 2022
cd2babd
make style
NouamaneTazi Dec 7, 2022
16d2e24
typing
NouamaneTazi Dec 7, 2022
0a5a52c
apply suggestions
NouamaneTazi Dec 7, 2022
b3f7bbb
Merge branch 'main' of https://github.com/huggingface/optimum into pr…
NouamaneTazi Dec 7, 2022
2ec8009
make style
NouamaneTazi Dec 7, 2022
2c1e907
Merge branch 'main' of https://github.com/huggingface/optimum into pr…
NouamaneTazi Dec 12, 2022
af664f8
apply suggestion
NouamaneTazi Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions optimum/onnxruntime/modeling_ort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,11 @@ def _save_pretrained(self, save_directory: Union[str, Path], file_name: Optional
"""
model_file_name = file_name if file_name is not None else ONNX_WEIGHTS_NAME

src_path = self.model_save_dir.joinpath(self.latest_model_name)
dst_path = Path(save_directory).joinpath(model_file_name)
shutil.copyfile(src_path, dst_path)
src_path = self.model_save_dir
dst_path = Path(save_directory)

# TODO: only copy the onnx model and external data
shutil.copytree(src_path, dst_path, dirs_exist_ok=True)

@classmethod
def _from_pretrained(
Expand Down