Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] use micro-conditioning for the SDXL trainers #6586

Open
2 of 6 tasks
sayakpaul opened this issue Jan 16, 2024 · 12 comments
Open
2 of 6 tasks

[Tracker] use micro-conditioning for the SDXL trainers #6586

sayakpaul opened this issue Jan 16, 2024 · 12 comments
Labels
advanced contributions-welcome stale Issues that haven't received updates

Comments

@sayakpaul
Copy link
Member

sayakpaul commented Jan 16, 2024

SDXL makes use of micro-conditioning, and it does have quite a bit of an effect on the end results. For more details, refer to the paper here.

Currently, not all of our SDXL trainers don't make use of micro-conditioning. So, it'd be nice to have micro-conditioning support as in https://github.com/huggingface/diffusers/blob/main/examples/text_to_image/train_text_to_image_lora_sdxl.py.

Below is a list of the training scripts where we'd like to have this change incorporated:

Feel free to open PRs targeting only ONE example at a time and tag me. Please also share an example training command while submitting the PRs. The command doesn't have to run the training for a large number of steps. Anything in the range of [4, 10] should suffice.

@sayakpaul
Copy link
Member Author

@jiqing-feng, would you like to take Textual inversion SDXL?

@linoytsaban would you like to take Advanced SDXL trainer?

@charchit7
Copy link
Contributor

charchit7 commented Jan 16, 2024

Hey @sayakpaul what's the min requirement for GPU while testing for the training?

@sayakpaul
Copy link
Member Author

DreamBooth SDXL LoRA should run in Colab. Refer to the associated readme for more details.

@linoytsaban
Copy link
Collaborator

@linoytsaban would you like to take Advanced SDXL trainer?

sure!

@jiqing-feng
Copy link
Contributor

@jiqing-feng, would you like to take Textual inversion SDXL?

@linoytsaban would you like to take Advanced SDXL trainer?

Sorry for the delay, I have been quite busy recently; I will do it once I have time.

@ChengsongLu
Copy link

ChengsongLu commented Jan 30, 2024

DreamBooth SDXL LoRA should run in Colab. Refer to the associated readme for more details.

Can it run locally?

@sayakpaul
Copy link
Member Author

You need to repurpose the code accordingly for that.

@cosmo3769
Copy link
Contributor

Hello @sayakpaul, I would love to work on ControlNet SDXL. Thank you.

@sayakpaul
Copy link
Member Author

Please go ahead.

@jiqing-feng
Copy link
Contributor

jiqing-feng commented Feb 26, 2024

Hi @sayakpaul . I think the micro conditioning is already in the example, see conditioning_image_size and conditioning_crop_size, and they are all in the add_time_ids.

BTW, I found a minor error about the resize function, and I already fixed it in #7095

@sayakpaul
Copy link
Member Author

You are right. Thanks for the quick fix.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced contributions-welcome stale Issues that haven't received updates
Projects
None yet
Development

No branches or pull requests

6 participants