Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDXL LoRA DreamBooth training] follow-up from #5508 #5941

Closed
sayakpaul opened this issue Nov 27, 2023 · 2 comments
Closed

[SDXL LoRA DreamBooth training] follow-up from #5508 #5941

sayakpaul opened this issue Nov 27, 2023 · 2 comments
Labels
stale Issues that haven't received updates

Comments

@sayakpaul
Copy link
Member

Some thoughts:

  • Reflect the updates introduced in Add features to the Dreambooth LoRA SDXL training script #5508 in README_sdxl.md. In particular, focus on:
    • The simple improvements. If a blog post is being planned, just briefly mentioning the supported stuff and referencing the blog post work for me.
    • Interplay between repeats, max_train_epochs, and num_train_epochs. repeats doesn't likely affect the other two. But for a regular practitioner, it can be quite confusing when they see these three popping up in the same place.
  • Rename to text_encoder_learning_rate for consistency with the other argument: learning_rate.
  • When can't we cache the custom prompts as well? Saves memory, no? Or was it not done to keep the script simple? In that case, I understand no further explanation is needed.

Cc: @linoytsaban

@sayakpaul
Copy link
Member Author

Gentle ping @linoytsaban.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 27, 2023
@github-actions github-actions bot closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

No branches or pull requests

1 participant