Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate text_encoder learning rate for LoRA scripts #5865

Closed
jmaccall316 opened this issue Nov 20, 2023 · 3 comments
Closed

Separate text_encoder learning rate for LoRA scripts #5865

jmaccall316 opened this issue Nov 20, 2023 · 3 comments
Labels
stale Issues that haven't received updates

Comments

@jmaccall316
Copy link

This is one I notice with LoRA you can train with a very high unet learning rate of 1e-4, but the text encoder being a separate entity I feel this lr is way too high, would be cool to have a bit more control over both.

@patrickvonplaten
Copy link
Contributor

There is an open PR here: #5508

@rmac85
Copy link

rmac85 commented Nov 22, 2023

There is an open PR here: #5508

Thanks, I know some of you guys are weary about bulking up the scripts too much and making them harder to use for beginners, but the text_encoder_lr at least for me is working well with SDXL LoRA. I'm still testing combos, but have achieved much better results already with a text_encoder_lr as low as 8e-7 compared to 1e-4.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 26, 2023
@github-actions github-actions bot closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

No branches or pull requests

3 participants