Mccalluc/previews to resources #2121
Conversation
|
@john-conroy -- After the merge from main, there was one link that changed, but there was still another Cypress error I didn't understand: The general idea is that an element is on the screen, so cypress starts working with it, but then its visibility changes, and chained methods fail. This kludge is suggested towards the end of a long thread. I did try upgrading Cypress, but that didn't fix anything. (Upgrading might still be good, but I didn't want to muddy the waters in this PR.) Re-review? |
| @@ -24,7 +24,8 @@ describe('file-based-routes', () => { | |||
| // TODO: When we link to it from the menu, follow the link instead. | |||
| cy.visit('/publication'); | |||
| cy.contains('Blue B. Lake'); | |||
| cy.contains('An atlas of healthy and injured cell states').click(); | |||
| // be.visible is a hack: https://github.com/cypress-io/cypress/issues/695 | |||
| cy.contains('An atlas of healthy and injured cell states').should('be.visible').click(); | |||
There was a problem hiding this comment.
Was this possibly considered 'not visible' before the hack because the test string provided isn't an exact match of what's on the page?
There was a problem hiding this comment.
You mean it's just a substring? I don't think that's a problem, but let me check...
There was a problem hiding this comment.
No, even if it's the full string, the failure is the same:
- cy.contains('An atlas of healthy and injured cell states').should('be.visible').click();
+ cy.contains('An atlas of healthy and injured cell states and niches in the human kidney').click();Good to confirm, though.
Fix #2120. The effect on the screen is negligible (change the menu title; prefix options with "preview") but it turned into a bigger refactor: Lots of renaming, and then it turned out that the Azimuth link wasn't beeing included in the narrow view, so move it inside the component, and then since the same pattern repeats 3 times, factor out just the parts that change between menus.