Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't add a pass before or after the first. #671

Closed
ghost opened this issue Jul 17, 2014 · 1 comment
Closed

Can't add a pass before or after the first. #671

ghost opened this issue Jul 17, 2014 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 17, 2014

Using before or after and providing the name of the first pass, the falsy check here: https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy/index.js#L146 will always indicate that the name could not be found.

Instead this should read something like if(i === false).

The same issue is present in after.
@jcrugzz
Copy link
Contributor

jcrugzz commented Jul 17, 2014

@justin-summerlin thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcrugzz