From 37fad7e04ce7f436a12836da2ef12f96200feb89 Mon Sep 17 00:00:00 2001
From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon, 2 May 2022 14:58:05 +0530
Subject: [PATCH] fix: convert default_item_manufacturer to link field (#30835)
 (#30866)

(cherry picked from commit dcda55641b822f62b9808c36027b59b5eaf697b3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
---
 erpnext/patches.txt                              |  1 +
 ...change_default_item_manufacturer_fieldtype.py | 16 ++++++++++++++++
 erpnext/stock/doctype/item/item.json             |  5 +++--
 3 files changed, 20 insertions(+), 2 deletions(-)
 create mode 100644 erpnext/patches/v13_0/change_default_item_manufacturer_fieldtype.py

diff --git a/erpnext/patches.txt b/erpnext/patches.txt
index 2fad1efa8328..d90a5e194887 100644
--- a/erpnext/patches.txt
+++ b/erpnext/patches.txt
@@ -358,6 +358,7 @@ erpnext.patches.v13_0.rename_non_profit_fields
 erpnext.patches.v13_0.enable_ksa_vat_docs #1
 erpnext.patches.v13_0.create_gst_custom_fields_in_quotation
 erpnext.patches.v13_0.update_expense_claim_status_for_paid_advances
+erpnext.patches.v13_0.change_default_item_manufacturer_fieldtype
 erpnext.patches.v13_0.set_return_against_in_pos_invoice_references
 erpnext.patches.v13_0.copy_custom_field_filters_to_website_item
 erpnext.patches.v13_0.education_deprecation_warning
diff --git a/erpnext/patches/v13_0/change_default_item_manufacturer_fieldtype.py b/erpnext/patches/v13_0/change_default_item_manufacturer_fieldtype.py
new file mode 100644
index 000000000000..0b00188e6a8d
--- /dev/null
+++ b/erpnext/patches/v13_0/change_default_item_manufacturer_fieldtype.py
@@ -0,0 +1,16 @@
+import frappe
+
+
+def execute():
+
+	# Erase all default item manufacturers that dont exist.
+	item = frappe.qb.DocType("Item")
+	manufacturer = frappe.qb.DocType("Manufacturer")
+
+	(
+		frappe.qb.update(item)
+		.set(item.default_item_manufacturer, None)
+		.left_join(manufacturer)
+		.on(item.default_item_manufacturer == manufacturer.name)
+		.where(manufacturer.name.isnull() & item.default_item_manufacturer.isnotnull())
+	).run()
diff --git a/erpnext/stock/doctype/item/item.json b/erpnext/stock/doctype/item/item.json
index e6f1f0a2952f..06baa0fe9127 100644
--- a/erpnext/stock/doctype/item/item.json
+++ b/erpnext/stock/doctype/item/item.json
@@ -918,8 +918,9 @@
   },
   {
    "fieldname": "default_item_manufacturer",
-   "fieldtype": "Data",
+   "fieldtype": "Link",
    "label": "Default Item Manufacturer",
+   "options": "Manufacturer",
    "read_only": 1
   },
   {
@@ -954,7 +955,7 @@
  "image_field": "image",
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2021-12-14 04:13:16.857534",
+ "modified": "2022-04-28 04:52:10.272256",
  "modified_by": "Administrator",
  "module": "Stock",
  "name": "Item",