Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insight into a valid JAR file #234

Closed
HttpMarco opened this issue Aug 22, 2024 · 3 comments
Closed

Insight into a valid JAR file #234

HttpMarco opened this issue Aug 22, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@HttpMarco
Copy link

Hey guys,

At the moment, I’m developing a Minecraft cluster. Many supporters have suggested that we should offer version 1.8.9. However, I don’t want to mess around with the original Paper and handle bytecode with Java 17. Instead, I would like to use your fork as a reference for 1.8.9.

The only problem: I only receive a ZIP link, not a JAR link. Therefore, it’s not possible for me to support it without extra effort. Could you perhaps add something to your pipeline? This is what it looks like on our end right now, where PandaSpigot should also be added soon: https://github.com/HttpMarco/polocloud/blob/dev/release/versions.json

It would be great if you could manage that somehow.

Best regards,
HttpMarco

@jirmjahu
Copy link

@hpfxd

@hpfxd
Copy link
Owner

hpfxd commented Aug 23, 2024

This is due to a limitation in how GitHub Actions handles artifact uploads; see actions/upload-artifact#426

Moving away from GH Actions and handling CI on my own infra is something I've considered for a long time and would allow for offering direct download links for JARs. Even without automated downloading by projects such as yours, this isn't the best user experience for end-users needing to unzip the downloaded file before use. I'll keep this issue open for now to track this being resolved.

As for right now, it seems like your options would be adding logic to unzip the downloaded file; or to setup some kind of service to proxy the JAR to be directly downloaded.

@hpfxd hpfxd added the enhancement New feature or request label Aug 31, 2024
@hpfxd
Copy link
Owner

hpfxd commented Aug 31, 2024

Implemented in 8393334

PandaSpigot now has a downloads API available at downloads.hpfxd.com. It is running a fork of bibliothek (Paper's download API), so should be compatible with your current process :) (source code is available here for anyone interested)

The following URL will redirect to a download of the Paperclip server JAR for the latest build: https://downloads.hpfxd.com/v2/projects/pandaspigot/versions/1.8.8/builds/latest/downloads/paperclip

@hpfxd hpfxd closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants