Rename "InstantClick" section #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo's link prefetching implementation is in no way affiliated with the pre-existing [InstantClick][] package. Turbo doesn't have a client-side dependency on the [instantclick package][], nor does it share any code with the [dieulot/instantclick][] repository. With this in mind, this commit removes all mentions of "InstantClick" from the site and renames the heading to "Prefetching Links on Hover". While editing that section, this commit also removes mention of handling `touchstart` events, since those events are not accounted for in the current implementation. [InstantClick]: http://instantclick.io [instantclick package]: https://www.npmjs.com/package/instantclick [dieulot/instantclick]: https://github.com/dieulot/instantclick
|
@afcapel @davidalejandroaguilar is "Prefetching Links on Hover" a suitable new name for this section? |
|
@seanpdoyle Hadn't realized we might not want users to think we're affiliated in some way. This makes sense and looks good to me. "Hover" might not be what's always happening (e.g. when we add Let's see what @afcapel thinks. |
|
Is "Prefetching Links" enough? |
seanpdoyle
commented
Mar 1, 2024
| @@ -328,11 +328,11 @@ If the form submission is a GET request, you may render the directly rendered re | |||
|
|
|||
| Servers may also respond to form submissions with a [Turbo Streams](streams) message by sending the header `Content-Type: text/vnd.turbo-stream.html` followed by one or more `<turbo-stream>` elements in the response body. This lets you update multiple parts of the page without navigating. | |||
|
|
|||
| ## InstantClick | |||
| ## Prefetching Links on Hover | |||
There was a problem hiding this comment.
Suggested change
| ## Prefetching Links on Hover | |
| ## Prefetching Links |
|
Makes sense, thanks @seanpdoyle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turbo's link prefetching implementation is in no way affiliated with the pre-existing InstantClick package. Turbo doesn't have a client-side dependency on the instantclick package, nor does it share any code with the dieulot/instantclick repository.
With this in mind, this commit removes all mentions of "InstantClick" from the site and renames the heading to "Prefetching Links on Hover".
While editing that section, this commit also removes mention of handling
touchstartevents, since those events are not accounted for in the current implementation.