Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layered configuration? #46

Closed
MikeGoldsmith opened this issue Jul 8, 2021 · 2 comments
Closed

Layered configuration? #46

MikeGoldsmith opened this issue Jul 8, 2021 · 2 comments

Comments

@MikeGoldsmith
Copy link
Contributor

Currently configuration can only be provided in one of the following ways:

  • create instance of HoneycombOptions
  • IConfiguration (eg appsettings.json)
  • command line args

However, a user cannot mix and match them. Eg set some command line args, some via configuration file, etc. Is this something we want to allow?

@bdarfler bdarfler added this to the Beta Release milestone Jul 12, 2021
@bdarfler bdarfler changed the title Layered configuration Layered configuration? Jul 19, 2021
@MikeGoldsmith
Copy link
Contributor Author

I think this is a nice to have and maybe not a requirement for the Beta milestone?

@MikeGoldsmith
Copy link
Contributor Author

MikeGoldsmith commented Jul 28, 2021

Currently the .NET OpenTelemetry SDK only supports direct code configuration and does not have a defined path for env vars or appsettings. A recent, unreleased, PR was merged to start to introduce env var support as defined in the spec, but this incomplete and could change before it's released.

The current .NET Honeycomb distro supports configuration via command line args, appsettings and command line args but doesn't support layered configuration. We feel this is okay for now as we won't break any base OpenTelemtry SDK configuration options and we can re-assess once the base OpenTelemetry SDK adds env var support.

Moving to Icebox for later consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants