Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use minified tabulator JS? #5795

Closed
cdeil opened this issue Nov 1, 2023 · 0 comments · Fixed by #6060
Closed

Use minified tabulator JS? #5795

cdeil opened this issue Nov 1, 2023 · 0 comments · Fixed by #6060
Labels
component: tabulator Related to the Tabulator widget good first issue Good for newcomers
Milestone
v1.3.5

Comments

@cdeil
Copy link
Contributor

cdeil commented Nov 1, 2023

I see (with versions and example from #5794) that Panel only bundles and serves tabulator.js whereas it otherwise uses minified JS for Bokeh, Panel, everything. See screenshot below.

Is there a reason? Would using tabulator.min.js simply be more performant or does that bring any issues or drawbacks?

Screenshot 2023-11-01 at 13 13 14
@philippjfr philippjfr added this to the v1.3.2 milestone Nov 1, 2023
@maximlt maximlt added the component: tabulator Related to the Tabulator widget label Nov 14, 2023
@philippjfr philippjfr modified the milestones: v1.3.2, v1.4.0 Nov 22, 2023
@philippjfr philippjfr added the good first issue Good for newcomers label Dec 6, 2023
@philippjfr philippjfr modified the milestones: v1.4.0, v1.3.5 Dec 15, 2023
@philippjfr philippjfr mentioned this issue Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabulator Related to the Tabulator widget good first issue Good for newcomers
Projects
None yet
Milestone
v1.3.5
Development

Successfully merging a pull request may close this issue.

Use minified Tabulator JS holoviz/panel
3 participants
@cdeil @philippjfr @maximlt