Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle doesn't show icon #4961

Closed
ahuang11 opened this issue May 28, 2023 · 2 comments · Fixed by #4969
Closed

Toggle doesn't show icon #4961

ahuang11 opened this issue May 28, 2023 · 2 comments · Fixed by #4969

Comments

@ahuang11
Copy link
Contributor

ahuang11 commented May 28, 2023 •
edited
Loading

https://panel.holoviz.org/reference/widgets/Toggle.html

image
@hoxbro
Copy link
Member

hoxbro commented May 28, 2023

This should be fixable by removing Icon here:

panel/panel/widgets/button.py

Line 272 in 81bbfaa

'value': 'active', 'name': 'label', 'icon': None, 'icon_size': None

image

@ahuang11
Copy link
Contributor Author

ahuang11 commented May 28, 2023 •
edited
Loading

Thanks for looking into it!

I'm wondering if there was a particular reason that 'icon' is None before just dropping it?

@hoxbro hoxbro mentioned this issue May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Icon to toggle holoviz/panel
2 participants
@ahuang11 @hoxbro