Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert_apps creates app with error #3924

Closed
MarcSkovMadsen opened this issue Oct 1, 2022 · 4 comments · Fixed by #3925 or #3926
Closed

convert_apps creates app with error #3924

MarcSkovMadsen opened this issue Oct 1, 2022 · 4 comments · Fixed by #3925 or #3926

Comments

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Oct 1, 2022

Issue 1

I'm on the current master branch

script.py

import panel as pn
pn.panel("Hello World").servable()

script2.py

from panel.io.convert import convert_apps

convert_apps(apps=["script.py"])
python 'script2.py'
python3 -m http.server

image

Uncaught SyntaxError: missing ) after argument list (at sharing?config=eyJhcHBzIjogeyJzY3JpcHQucHkiOiAiXG5pbXBvcnQgcGFuZWwgYXMgcG5cbnBuLnBhbmVsKFwiSGVsbG8gV29ybGRcIikuc2VydmFibGUoKVxuIn19:38:3)

I believe its missing a ) here

image

@MarcSkovMadsen MarcSkovMadsen added this to the Version 0.14.0 milestone Oct 1, 2022
@MarcSkovMadsen MarcSkovMadsen changed the title convert_apps creates app with error: convert_apps creates app with error: Uncaught SyntaxError: missing ) after argument list Oct 1, 2022
@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 1, 2022

Issue 2

If I add the missing ) I get another error because serviceWorker.js is not created by convert_apps

image

image

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 1, 2022

Issue 3

If I convert using convert_apps(apps=["script.py"], build_index=False, build_pwa=False) it bypasses the above errors but I am left with the error in #3921

image

Update: The error I am left with is actually #3919 not #3921

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 1, 2022

This does not solve the entire issue unfortunately. I'm still left with #Issue2 and #Issue3

After inspection of #Issue3 I can see the issue is that await self.pyodide.runPythonAsync(code) returns undefined.

image

This is also the issue I end up having here #3919

@MarcSkovMadsen MarcSkovMadsen changed the title convert_apps creates app with error: Uncaught SyntaxError: missing ) after argument list convert_apps creates app with error Oct 1, 2022
@philippjfr
Copy link
Member

Will set up some tests for the pyodide-worker runtime option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants