Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorter automatically applied on a cell edit #3659

Closed
maximlt opened this issue Jun 29, 2022 · 3 comments · Fixed by #3744
Closed

Sorter automatically applied on a cell edit #3659

maximlt opened this issue Jun 29, 2022 · 3 comments · Fixed by #3744
Labels
component: tabulator Related to the Tabulator widget type: discussion Requiring community discussion

Comments

@maximlt
Copy link
Member

maximlt commented Jun 29, 2022

Currently when a cell is edited in a column that has a sorter applied the sorter is automatically re-applied. I believe we introduced this behavior recently and in hindsight I don't think it's correct. If I intend to edit more than one cell per row then the fact that the table is resorted after the edit forces me to find the row again to keep editing it. This is disrupting in a session with many edits expected.

The default behavior of Tabulator is not to apply the sorters after a cell edit, this can be tested here: http://tabulator.info/examples/5.2#editable

@philippjfr thoughts on that?

@maximlt maximlt added type: discussion Requiring community discussion component: tabulator Related to the Tabulator widget labels Jun 29, 2022
@philippjfr
Copy link
Member

Agree this is an issue of course but my question is, when should the sorter be reapplied? If it's not reapplied at all that seems quite inconsistent. I'd be okay with reverting the change though.

@maximlt
Copy link
Member Author

maximlt commented Jun 30, 2022

To re-apply a sorter after a cell edit you would need to click again on the UI sorters to trigger them. That's what Tabulator JS offers by default and I believe that's what you get in Excel/GSheet.

@philippjfr
Copy link
Member

Sounds good, please feel free to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabulator Related to the Tabulator widget type: discussion Requiring community discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants