-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explorer: add cancel button to stop processing #1218
Comments
I think we've already discussed that in the past. IIRC it's pretty difficult to stop things from running. I think we discussed removing columns from |
I was imagining this |
+1. I am trying to build a custom data catalogue inspired by Intake. I would like my users to be able to explore a source using the It would be very helpful with one or more of the below.
I think it could be possible to implement support for some limits to not include columns with |
The explorer is pretty different from the chat components of Panel, it doesn't fetch data from the internet, which is indeed the kind of operation that can get very slow (e.g. rated limited API) and you may want to stop. Ideally the explorer should not have slow and blocking operations, as you can't explore data when things get too slow :) ! Sure we could try to add a cancel button to stop processing but before jumping on that kind of engineer solution I'd like to look into potential UX solutions. Like:
|
Agree with @maximlt, the solution is not to allow a user to back out of some nonsensical selection that will, at best, cause lengthy processing in Python or at worst crash your browser, but rather prevent users from making such selections in the first place. Indeed in many cases there is no backing out, often the actual Python portion of the processing finishes very quickly but once Bokeh is asked to render the output it effectively freezes the browser, at which point it's too late. I too suggest we do some of the following:
|
I agree that we should try to limit to risk of a user selecting something that blocks. But I also believe that it would mean a lot of the plot could be generated in its own thread by default. As it is now the explorer will not really work in a shared application because it will be blocking the main thread over and over again for 0.1-5 secs. Maybe Panel should provide its own implementation of |
Very doubtful that threading hvPlot would meaningfully unlock the GIL. |
Sometimes, accidentally click on a column name with over 1000 unique groups for
by
and then it takes forever unless I Cmd+C or restart kernel.The text was updated successfully, but these errors were encountered: