Build guide: validation #520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucture-zome-functions
…e/app-structure-dnas
mattyg
reviewed
Feb 25, 2025
ThetaSinner
reviewed
Feb 25, 2025
jost-s
previously approved these changes
Feb 25, 2025
Co-authored-by: mattyg <matt@buildyourweb.app>
Co-authored-by: mattyg <matt@buildyourweb.app>
Co-authored-by: mattyg <matt@buildyourweb.app>
Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com>
Co-authored-by: mattyg <matt@buildyourweb.app>
Co-authored-by: mattyg <matt@buildyourweb.app>
…es into feat/guide/validation
dad5a30 to
54ae9b3
Compare
b729931 to
6247022
Compare
6247022 to
34da873
Compare
Co-authored-by: mattyg <matt@buildyourweb.app>
…es into feat/guide/validation
mattyg
approved these changes
Feb 26, 2025
|
@mattyg I notice you approved this PR -- is that with or without resolution of the following? |
Ah my bad I didn't click through all the "hidden" comments, I assumed it would show my own comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #475 .
This PR depends on #516 and #517 . Don't review until they're merged.
So while this PR reflects my attempts to simplify the work I'm doing on the Build Guide, it doesn't incorporate the feedback I got today to simplify even more. So it does do some explanatory stuff that may or may not be necessary. Feel free to offer feedback on whether it's too much information, with the caveat that I'll be using that feedback in future PRs and will probably leave this one as it is, because it's already been written and it's probably useful information. (That said, if you feel it gets in the way, please explicitly say that you think it should be removed.)
Covers:
validatecallbackgenesis_self_checkcallbackmust_get_*