Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App structure: hApps #517

Merged
merged 36 commits into from
Feb 11, 2025
Merged

App structure: hApps #517

merged 36 commits into from
Feb 11, 2025

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Jan 22, 2025 •
edited
Loading

Closes #489. Depends on #516 , which depends on #512. Don't review until those are merged, cuz otherwise this PR will seem bigger than it really is.

pdaoust added 30 commits January 15, 2025 13:33
@pdaoust
lifecycle callbacks and zome functions pages
f154488
@pdaoust
add new pages to navs
8fc90cd
@pdaoust
link up all references to two new pages
ae585c0
@pdaoust
remove redundant descriptions of lifecycles, add examples for relaxed
e20390e 
ordering
@pdaoust
add under-the-hood for CreateLink and DeleteLink
f16a4a5
@pdaoust
add snapshotted to dict
cd3eee3
@pdaoust
fix broken JSON
2ccb02d
@pdaoust
fix broken links
5cb51e1
@pdaoust
fix hdk_entry_defs, whoops
60cf346
@pdaoust
add example for post_commit
060a7d8
@pdaoust
simplify/elaborate post_commit example
1010a44
@pdaoust
Merge branch 'feat/guide/app-structure-zomes' into feat/guide/app-str…
39813c0 
…ucture-zome-functions
@pdaoust
improve language around callbacks and lifecycle hooks, plus a couple …
5103988 
…tiny edits
@pdaoust
little bit more of the same
0cc2fca
@pdaoust
test/fix all code samples in callbacks page
a1c3af3
@pdaoust
small edits to callbacks page
26b63dd
@pdaoust
link from identifiers to post_commit page (plus a typo fix)
e2c3f7b
@pdaoust
reference/further reading for zomes and callbacks pages
2a74d82
@pdaoust
Merge branch 'feat/guide/app-structure-zome-functions' into feat/guid…
f7d3638 
…e/app-structure-dnas
@pdaoust
DNAs page
05fbd84
@pdaoust
add DNAs page to nav and other references
445e799
@pdaoust
mention using a Cargo workspace
f618460
@pdaoust
try to fix JSON syntax error which doesn't appear to exist
a8e63fb
@pdaoust
fix broken URLs and a typo
994c997
@pdaoust
WIP
12c7985
@pdaoust
add section to DNAs on remote calling
854c45b
@pdaoust
Merge branch 'feat/guide/app-structure-dnas' into feat/guide/app-stru…
7ecf6d5 
…cture-happs
@pdaoust
add DNAs and hApps to build guide overview
cf2afe5
@pdaoust
hApps page draft
b948adb
@pdaoust
change note about clone_limit
45d90ba
@pdaoust pdaoust force-pushed the feat/guide/app-structure-happs branch from 8aabff7 to dbb573b Compare January 23, 2025 17:20
@pdaoust pdaoust requested review from zippy and mattyg January 23, 2025 17:21
@pdaoust pdaoust marked this pull request as ready for review January 23, 2025 17:21
@pdaoust pdaoust mentioned this pull request Feb 4, 2025
Open
@pdaoust pdaoust requested a review from c12i February 5, 2025 18:44
@pdaoust pdaoust mentioned this pull request Feb 7, 2025
Open
zippy
zippy previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes suggestions. Looks good as a first pass. I think we need to improve how we talk about scaffold based instructions or the "do-it-yourself" instructions. I think it might make sense that in our first level build we assume that code was generated from the scaffold, and then describe how to tweak the files generated from it. Then the hc app init and hc web-app init commands are in a separate "so-you-wanna-do-this-the-hard-way" section.

@pdaoust @zippy
Apply suggestions from code review
e744bd8 
Co-authored-by: Eric Harris-Braun <eric@harris-braun.com>
@pdaoust pdaoust enabled auto-merge (squash) February 10, 2025 23:10
@pdaoust
Copy link
Collaborator Author

pdaoust commented Feb 10, 2025

Minor fixes suggestions. Looks good as a first pass. I think we need to improve how we talk about scaffold based instructions or the "do-it-yourself" instructions. I think it might make sense that in our first level build we assume that code was generated from the scaffold, and then describe how to tweak the files generated from it. Then the hc app init and hc web-app init commands are in a separate "so-you-wanna-do-this-the-hard-way" section.

Agreed, and I'm moving more and more to the "just show it the way it would be if it were scaffolded" approach -- I've removed or deprioritised a lot of the DIY stuff already in this and future PRs, and I can see it being a good thing to hide it in an expandable section or an addendum or something.

zippy
zippy approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pdaoust pdaoust merged commit d3f0ab5 into main Feb 11, 2025
6 checks passed
@pdaoust pdaoust deleted the feat/guide/app-structure-happs branch February 11, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zippy zippy zippy approved these changes

@mattyg mattyg Awaiting requested review from mattyg

@c12i c12i Awaiting requested review from c12i

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App structure 3: hApp and webHapp manifest and bundle formats
3 participants
@pdaoust @zippy @c12i