Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate core gene tree #56

Closed
hoelzer opened this issue Aug 19, 2023 · 1 comment
Closed

Calculate core gene tree #56

hoelzer opened this issue Aug 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@hoelzer
Copy link
Contributor

hoelzer commented Aug 19, 2023

At the moment, we calculate a --tree from all RIBAP groups that have all input species. E.g., when there are 28 input genomes we search for MSAs that have 28 genes in the filter_alignment step.

This can fail when there are no such MSAs, see #54

A solution can be, that we search for MSAs with n-1 species if there are no with n species. However, we need to check how this impacts the core gene MSA and final tree calculations. It can then also happen, that species that were given as input do not show up in the tree (e.g. when there is a species that does not have any core gene with all the other species, but then does a core gene tree anyway make sense?)

@hoelzer hoelzer added the enhancement New feature or request label Aug 19, 2023
@hoelzer
Copy link
Contributor Author

hoelzer commented May 17, 2024

Should be fixed with a solution in https://github.com/hoelzer-lab/ribap/releases/tag/1.0.2

@hoelzer hoelzer closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant