Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCSLayer #287

Open
manzt opened this issue Oct 26, 2020 · 1 comment
Open

HCSLayer #287

manzt opened this issue Oct 26, 2020 · 1 comment

Comments

@manzt
Copy link
Member

manzt commented Oct 26, 2020

Since there is a way to express a HCS layout in both OME-XML and OME-Zarr, it might be beneficial to add a special layer to viv. In vizarr, @will-moore has explored using many ImageLayers hms-dbmi/vizarr#43.

Proposal

Add an HCSLayer to display a grid of images with the same rendering settings. This should have the same API as ImageLayer and MultiscaleImageLayer except it should take a loaders rather than loader as a prop.

const gridLayer = new HCSLayer({
	id: 'my-layer',
    loaders, // { 'A1': loader0, 'A2' loader1, 'A3': loader3, ...etc } or something similar?
	loaderSelection,
    colorValues,
    sliderValues,
    ...props
});

Potential issues

Although OME-XML and OME-Zarr both express the HCS layout, we treat the formats differently with our loaders. The OME-TIFF loader will need some work to be interchangeable here with something that is zarr-based. I think this might be a good opportunity to refactor the loaders and unify what a lazy-nd array is for viv.

@ilan-gold
Copy link
Collaborator

Just putting a reminder here for myself or future developers, but HuBMAP has a potential use-case for a grid-layer for comparing different datasets (not just HCS) quickly and easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants