Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool utils need imporve #6540

Closed
zhang001122 opened this issue Jan 6, 2025 · 0 comments
Closed

tool utils need imporve #6540

zhang001122 opened this issue Jan 6, 2025 · 0 comments
Labels
wontfix This will not be worked on

Comments

@zhang001122
Copy link

Description

llamafactory define lots of python file for different use of model tool
while vllm use jinja to generate tool dataset https://github.com/vllm-project/vllm/blob/main/examples/tool_chat_template_llama3.2_json.jinja

I think if we use this jinja to generate and degenerate will be better

Pull Request

No response
@zhang001122 zhang001122 added the enhancement New feature or request label Jan 6, 2025
@github-actions github-actions bot added the pending This problem is yet to be addressed label Jan 6, 2025
@hiyouga hiyouga added wontfix This will not be worked on and removed enhancement New feature or request pending This problem is yet to be addressed labels Jan 6, 2025
@hiyouga hiyouga closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hiyouga @zhang001122