hideved, csfixed

hiqdev · May 5, 2017 · 48eb728 · 48eb728
1 parent 58155c6
commit 48eb728
Show file tree

Hide file tree

Showing 22 changed files with 192 additions and 103 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,7 +1,9 @@
 # hidev internals
 .hidev/composer.json
 .hidev/composer.lock
+.hidev/runtime
 .hidev/vendor
+hidev-local.yml
 
 # IDE & OS files
 .*.swp
@@ -13,18 +15,24 @@
 Thumbs.db
 nbproject
 
-# php-cs-fixer cache
-.php_cs.cache
-
 # vendor dirs
 vendor
 
 # composer lock files
 composer.lock
 
+# php-cs-fixer cache
+.php_cs.cache
+
 # phpunit generated files
 coverage.clover
 
+# Binaries
+chkipper.phar
+composer.phar
+ocular.phar
+phpunit-skelgen.phar
+
 # PHARs
 php-cs-fixer.phar
 phpunit.phar
diff --git a/.php_cs b/.php_cs
@@ -6,48 +6,48 @@ ePayService driver for the Omnipay PHP payment processing library
 @link      https://github.com/hiqdev/omnipay-epayservice
 @package   omnipay-epayservice
 @license   MIT
-@copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
+@copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 EOF;
 
-Symfony\CS\Fixer\Contrib\HeaderCommentFixer::setHeader($header);
-
-return Symfony\CS\Config\Config::create()
+return PhpCsFixer\Config::create()
     ->setUsingCache(true)
-    ->level(Symfony\CS\FixerInterface::SYMFONY_LEVEL)
-    ->fixers([
-        '-long_array_syntax',                    /// Arrays should use the long syntax.
-        '-php4_constructor',                     /// Convert PHP4-style constructors to __construct. Warning! This could change code behavior.
-        '-phpdoc_var_to_type',                   /// @var should always be written as @type.
-        '-align_double_arrow',                   /// Align double arrow symbols in consecutive lines.
-        '-unalign_double_arrow',                 /// Unalign double arrow symbols in consecutive lines.
-        '-align_equals',                         /// Align equals symbols in consecutive lines.
-        '-unalign_equals',                       /// Unalign equals symbols in consecutive lines.
-        '-blankline_after_open_tag',             /// Ensure there is no code on the same line as the PHP open tag and it is followed by a blankline.
-        '-phpdoc_no_empty_return',               /// @return void and @return null annotations should be omitted from phpdocs.
-        '-empty_return',                         /// A return statement wishing to return nothing should be simply "return".
-        '-return',                               /// An empty line feed should precede a return statement.
-        '-phpdoc_params',                        /// All items of the @param, @throws, @return, @var, and @type phpdoc tags must be aligned vertically.
-        '-phpdoc_scalar',                        /// Scalar types should always be written in the same form. "int", not "integer"; "bool", not "boolean".
-        '-phpdoc_separation',                    /// Annotations of a different type are separated by a single blank line.
-        'header_comment',                        /// Add, replace or remove header comment.
-        'concat_with_spaces',                    /// Concatenation should be used with at least one whitespace around.
-        'ereg_to_preg',                          /// Replace deprecated ereg regular expression functions with preg. Warning! This could change code behavior.
-        'multiline_spaces_before_semicolon',     /// Multi-line whitespace before closing semicolon are prohibited.
-        'newline_after_open_tag',                /// Ensure there is no code on the same line as the PHP open tag.
-        'single_blank_line_before_namespace',    /// There should be no blank lines before a namespace declaration.
-        'ordered_use',                           /// Ordering use statements.
-        'phpdoc_order',                          /// Annotations in phpdocs should be ordered so that @param come first, then @throws, then @return.
-        'pre_increment',                         /// Pre incrementation/decrementation should be used if possible.
-        'short_array_syntax',                    /// PHP arrays should use the PHP 5.4 short-syntax.
-        'strict',                                /// Comparison should be strict. Warning! This could change code behavior.
-        'strict_param',                          /// Functions should be used with $strict param. Warning! This could change code behavior.
-    ])
-    ->finder(
-        Symfony\CS\Finder\DefaultFinder::create()
+    ->setRiskyAllowed(true)
+    ->setRules(array(
+        '@Symfony' => true,
+        'header_comment'                             =>  [
+            'header'        => $header,
+            'separate'      => 'bottom',
+            'location'      => 'after_declare_strict',
+            'commentType'   => 'PHPDoc',
+        ],
+        'binary_operator_spaces'                     =>  [
+            'align_double_arrow' => null,
+            'align_equals'       => null,
+        ],
+        'concat_space'                               =>  ['spacing' => 'one'],
+        'array_syntax'                               =>  ['syntax' => 'short'],
+        'phpdoc_no_alias_tag'                        =>  ['replacements' => ['type' => 'var']],
+        'blank_line_before_return'                   =>  false,
+        'phpdoc_align'                               =>  false,
+        'phpdoc_scalar'                              =>  false,
+        'phpdoc_separation'                          =>  false,
+        'phpdoc_to_comment'                          =>  false,
+        'method_argument_space'                      =>  false,
+        'ereg_to_preg'                               =>  true,
+        'blank_line_after_opening_tag'               =>  true,
+        'single_blank_line_before_namespace'         =>  true,
+        'ordered_imports'                            =>  true,
+        'phpdoc_order'                               =>  true,
+        'pre_increment'                              =>  true,
+        'strict_comparison'                          =>  true,
+        'strict_param'                               =>  true,
+        'no_multiline_whitespace_before_semicolons'  =>  true,
+    ))
+    ->setFinder(
+        PhpCsFixer\Finder::create()
             ->in(__DIR__)
             ->notPath('vendor')
             ->notPath('runtime')
             ->notPath('web/assets')
-            ->notPath('tests/unit/UnitTester.php')
-    )
+        )
 ;
diff --git a/.travis.yml b/.travis.yml
@@ -1,9 +1,10 @@
 language: php
 php:
-    - 5.5
     - 5.6
     - 7
+    - 7.1
     - hhvm
+dist: trusty
 matrix:
     allow_failures:
         -
@@ -16,11 +17,11 @@ before_install:
     - 'composer --version'
     - 'wget http://hiqdev.com/hidev/hidev.phar -O hidev.phar && chmod a+x hidev.phar'
     - './hidev.phar --version'
-    - './hidev.phar travis/before_install'
+    - './hidev.phar travis/before-install'
 sudo: false
 install:
     - './hidev.phar travis/install'
 script:
     - './hidev.phar travis/script'
 after_script:
-    - './hidev.phar travis/after_script'
+    - './hidev.phar travis/after-script'
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,10 +1,20 @@
-hiqdev/omnipay-epayservice changelog
-------------------------------------
+hiqdev/omnipay-epayservice
+--------------------------
 
-## Under development
+## [Under development]
 
-- Changed: redone to `omnipay-epayservice`
-- Added basics
+- Changed: redone to `omnipay-epayservice` ([@hiqsol])
+- Added basics ([@hiqsol])
 
-## Development started 2015-10-23
+## [Development started] - 2015-10-23
 
+[@hiqsol]: https://github.com/hiqsol
+[sol@hiqdev.com]: https://github.com/hiqsol
+[@SilverFire]: https://github.com/SilverFire
+[d.naumenko.a@gmail.com]: https://github.com/SilverFire
+[@tafid]: https://github.com/tafid
+[andreyklochok@gmail.com]: https://github.com/tafid
+[@BladeRoot]: https://github.com/BladeRoot
+[bladeroot@gmail.com]: https://github.com/BladeRoot
+[Under development]: https://github.com/hiqdev/omnipay-epayservice/releases
+[Under]: https://github.com/hiqdev/omnipay-epayservice/releases/tag/Under
diff --git a/LICENSE b/LICENSE
@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright © 2015-2016, HiQDev (http://hiqdev.com/)
+Copyright © 2015-2017, HiQDev (http://hiqdev.com/)
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/README.md b/README.md
@@ -1,13 +1,12 @@
-Omnipay: ePayService
-====================
+# Omnipay: ePayService
 
 **ePayService driver for the Omnipay PHP payment processing library**
 
 [![Latest Stable Version](https://poser.pugx.org/hiqdev/omnipay-epayservice/v/stable)](https://packagist.org/packages/hiqdev/omnipay-epayservice)
 [![Total Downloads](https://poser.pugx.org/hiqdev/omnipay-epayservice/downloads)](https://packagist.org/packages/hiqdev/omnipay-epayservice)
 [![Build Status](https://img.shields.io/travis/hiqdev/omnipay-epayservice.svg)](https://travis-ci.org/hiqdev/omnipay-epayservice)
-[![Code Coverage](https://scrutinizer-ci.com/g/hiqdev/omnipay-epayservice/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/hiqdev/omnipay-epayservice/?branch=master)
-[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/hiqdev/omnipay-epayservice/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/hiqdev/omnipay-epayservice/?branch=master)
+[![Scrutinizer Code Coverage](https://img.shields.io/scrutinizer/coverage/g/hiqdev/omnipay-epayservice.svg)](https://scrutinizer-ci.com/g/hiqdev/omnipay-epayservice/)
+[![Scrutinizer Code Quality](https://img.shields.io/scrutinizer/g/hiqdev/omnipay-epayservice.svg)](https://scrutinizer-ci.com/g/hiqdev/omnipay-epayservice/)
 [![Dependency Status](https://www.versioneye.com/php/hiqdev:omnipay-epayservice/dev-master/badge.svg)](https://www.versioneye.com/php/hiqdev:omnipay-epayservice/dev-master)
 
 [Omnipay](https://github.com/omnipay/omnipay) is a framework agnostic, multi-gateway payment
@@ -58,4 +57,4 @@ or better yet, fork the library and submit a pull request.
 This project is released under the terms of the MIT [license](LICENSE).
 Read more [here](http://choosealicense.com/licenses/mit).
 
-Copyright © 2015-2016, HiQDev (http://hiqdev.com/)
+Copyright © 2015-2017, HiQDev (http://hiqdev.com/)
diff --git a/chkipper.json b/chkipper.json
@@ -0,0 +1,33 @@
+{
+    "name": "hiqdev/omnipay-epayservice",
+    "authors": {
+        "hiqsol": {
+            "name": "Andrii Vasyliev",
+            "role": "Project lead",
+            "email": "sol@hiqdev.com",
+            "github": "https://github.com/hiqsol",
+            "homepage": "http://hipanel.com/"
+        },
+        "SilverFire": {
+            "name": "Dmitry Naumenko",
+            "role": "Lead backend developer",
+            "email": "d.naumenko.a@gmail.com",
+            "github": "https://github.com/SilverFire",
+            "homepage": "http://silverfire.me/"
+        },
+        "tafid": {
+            "name": "Andrey Klochok",
+            "role": "Lead frontend developer",
+            "email": "andreyklochok@gmail.com",
+            "github": "https://github.com/tafid",
+            "homepage": "http://hiqdev.com/"
+        },
+        "BladeRoot": {
+            "name": "Yuriy Myronchuk",
+            "role": "QA Lead",
+            "email": "bladeroot@gmail.com",
+            "github": "https://github.com/BladeRoot",
+            "homepage": "http://hiqdev.com/"
+        }
+    }
+}
diff --git a/.hidev/config.yml → hidev.yml b/.hidev/config.yml → hidev.yml
diff --git a/history.md b/history.md
@@ -0,0 +1,49 @@
+hiqdev/omnipay-epayservice
+--------------------------
+
+## [Under development]
+
+- Implemented testing
+    - [58155c6] 2017-05-05 Merge pull request #1 from bladeroot/omnipay-epayservice-test [@SilverFire]
+    - [261e5ee] 2017-04-28 finish [@BladeRoot]
+    - [39050a9] 2017-04-24 omnipay-epayservice-test init [@BladeRoot]
+- Changed: redone to `omnipay-epayservice`
+    - [4aa66f3] 2016-01-18 inited empty tests [@hiqsol]
+    - [57636af] 2016-01-17 fixed build [@hiqsol]
+    - [3722b88] 2015-12-11 removed assets, now in `payment-icons` [@hiqsol]
+    - [6fa42cb] 2015-11-11 still redoing to omnipay [@hiqsol]
+    - [219c624] 2015-11-11 still redoing to omnipay [@hiqsol]
+    - [83a13d4] 2015-11-06 started redoing to `omnipay-epayservice` [@hiqsol]
+- Added basics
+    - [5ef79f3] 2015-10-31 fixed `_secret` <- `secret` [@hiqsol]
+    - [6d5fc32] 2015-10-30 changed: redone to `system` <- `name` [@hiqsol]
+    - [db8df57] 2015-10-23 php-cs-fixed [@hiqsol]
+    - [d593d7b] 2015-10-23 hideved [@hiqsol]
+    - [6997451] 2015-10-23 inited [@hiqsol]
+
+## [Development started] - 2015-10-23
+
+[@hiqsol]: https://github.com/hiqsol
+[sol@hiqdev.com]: https://github.com/hiqsol
+[@SilverFire]: https://github.com/SilverFire
+[d.naumenko.a@gmail.com]: https://github.com/SilverFire
+[@tafid]: https://github.com/tafid
+[andreyklochok@gmail.com]: https://github.com/tafid
+[@BladeRoot]: https://github.com/BladeRoot
+[bladeroot@gmail.com]: https://github.com/BladeRoot
+[4aa66f3]: https://github.com/hiqdev/omnipay-epayservice/commit/4aa66f3
+[57636af]: https://github.com/hiqdev/omnipay-epayservice/commit/57636af
+[3722b88]: https://github.com/hiqdev/omnipay-epayservice/commit/3722b88
+[6fa42cb]: https://github.com/hiqdev/omnipay-epayservice/commit/6fa42cb
+[219c624]: https://github.com/hiqdev/omnipay-epayservice/commit/219c624
+[83a13d4]: https://github.com/hiqdev/omnipay-epayservice/commit/83a13d4
+[5ef79f3]: https://github.com/hiqdev/omnipay-epayservice/commit/5ef79f3
+[6d5fc32]: https://github.com/hiqdev/omnipay-epayservice/commit/6d5fc32
+[db8df57]: https://github.com/hiqdev/omnipay-epayservice/commit/db8df57
+[d593d7b]: https://github.com/hiqdev/omnipay-epayservice/commit/d593d7b
+[6997451]: https://github.com/hiqdev/omnipay-epayservice/commit/6997451
+[58155c6]: https://github.com/hiqdev/omnipay-epayservice/commit/58155c6
+[261e5ee]: https://github.com/hiqdev/omnipay-epayservice/commit/261e5ee
+[39050a9]: https://github.com/hiqdev/omnipay-epayservice/commit/39050a9
+[Under development]: https://github.com/hiqdev/omnipay-epayservice/releases
+[Under]: https://github.com/hiqdev/omnipay-epayservice/releases/tag/Under
diff --git a/src/Gateway.php b/src/Gateway.php
@@ -1,12 +1,11 @@
 <?php
-
-/*
- * ePayService driver for the Omnipay PHP payment processing library
+/**
+ * ePayService driver for the Omnipay PHP payment processing library.
  *
  * @link      https://github.com/hiqdev/omnipay-epayservice
  * @package   omnipay-epayservice
  * @license   MIT
- * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
+ * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
  */
 
 namespace Omnipay\ePayService;

diff --git a/src/Message/AbstractRequest.php b/src/Message/AbstractRequest.php
@@ -1,12 +1,11 @@
 <?php
-
-/*
- * ePayService driver for the Omnipay PHP payment processing library
+/**
+ * ePayService driver for the Omnipay PHP payment processing library.
  *
  * @link      https://github.com/hiqdev/omnipay-epayservice
  * @package   omnipay-epayservice
  * @license   MIT
- * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
+ * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
  */
 
 namespace Omnipay\ePayService\Message;

diff --git a/src/Message/CompletePurchaseRequest.php b/src/Message/CompletePurchaseRequest.php
@@ -1,12 +1,11 @@
 <?php
-
-/*
- * ePayService driver for the Omnipay PHP payment processing library
+/**
+ * ePayService driver for the Omnipay PHP payment processing library.
  *
  * @link      https://github.com/hiqdev/omnipay-epayservice
  * @package   omnipay-epayservice
  * @license   MIT
- * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
+ * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
  */
 
 namespace Omnipay\ePayService\Message;

diff --git a/src/Message/CompletePurchaseResponse.php b/src/Message/CompletePurchaseResponse.php
@@ -1,12 +1,11 @@
 <?php
-
-/*
- * ePayService driver for the Omnipay PHP payment processing library
+/**
+ * ePayService driver for the Omnipay PHP payment processing library.
  *
  * @link      https://github.com/hiqdev/omnipay-epayservice
  * @package   omnipay-epayservice
  * @license   MIT
- * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
+ * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
  */
 
 namespace Omnipay\ePayService\Message;

diff --git a/src/Message/PurchaseRequest.php b/src/Message/PurchaseRequest.php
@@ -1,12 +1,11 @@
 <?php
-
-/*
- * ePayService driver for the Omnipay PHP payment processing library
+/**
+ * ePayService driver for the Omnipay PHP payment processing library.
  *
  * @link      https://github.com/hiqdev/omnipay-epayservice
  * @package   omnipay-epayservice
  * @license   MIT
- * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
+ * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
  */
 
 namespace Omnipay\ePayService\Message;

diff --git a/src/Message/PurchaseResponse.php b/src/Message/PurchaseResponse.php
@@ -1,12 +1,11 @@
 <?php
-
-/*
- * ePayService driver for the Omnipay PHP payment processing library
+/**
+ * ePayService driver for the Omnipay PHP payment processing library.
  *
  * @link      https://github.com/hiqdev/omnipay-epayservice
  * @package   omnipay-epayservice
  * @license   MIT
- * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
+ * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
  */
 
 namespace Omnipay\ePayService\Message;