From 4ec1566c9fc888dbc264f5dfa627b16752c3f6ce Mon Sep 17 00:00:00 2001 From: Hilton Janfield Date: Sat, 12 Sep 2015 01:27:50 -0700 Subject: [PATCH] Change signature of onDrag* events. --- CHANGELOG.md | 2 ++ demo.html | 6 ++++++ js/jquery.enhsplitter.js | 8 ++++---- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0dd5a29..c89bd50 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ Changes made so far over v1.1.0. - Implemented drag-delay if the user clicks on the collapse handle then starts dragging. Drag will not begin until mouse has moved past 5 pixels in either direction. (UX improvement) - Prevent click event if the user started and ended their drag on the collapse handle. (UX improvement) - Change splitter bar class from .splitter to .splitter_bar for consistency. +- Fixed issue where collapse handle would ignore one click if manually dragged to the collapsed position. (UX improvement/bug) +- Modified onDrag, onDragStart, onDragEnd events to pass splitter container for easy manipulation. ## Release v1.1.0 diff --git a/demo.html b/demo.html index 0c5b6b9..fe6072d 100644 --- a/demo.html +++ b/demo.html @@ -473,23 +473,29 @@

Options

onDragStart
+ function (event, splitter_container) { ... } Default: $.noop

Event handler called when a user starts dragging a splitter.

+

Parameters passed are the standard event handler data, and the .splitter_container object.

onDragEnd
+ function (event, splitter_container) { ... } Default: $.noop

Event handler called when a user stops dragging a splitter.

+

Parameters passed are the standard event handler data, and the .splitter_container object.

onDrag
+ function (event, splitter_container) { ... } Default: $.noop

Event handler called after a user moves a splitter.

+

Parameters passed are the standard event handler data, and the .splitter_container object.

diff --git a/js/jquery.enhsplitter.js b/js/jquery.enhsplitter.js index ffa3ae7..0a75ba0 100644 --- a/js/jquery.enhsplitter.js +++ b/js/jquery.enhsplitter.js @@ -254,7 +254,7 @@ currentSplitter.find('.splitter_panel').trigger('resize.splitter'); e.preventDefault(); $('.splitter_mask').remove(); - currentSplitter.settings.onDrag(e); + currentSplitter.settings.onDrag(e, currentSplitter); } currentSplitter.removeClass('splitter-active'); currentSplitter = null; @@ -277,7 +277,7 @@ } else { currentSplitter.addClass('splitter-active'); $('
').css('cursor', currentSplitter.children().eq(1).css('cursor')).insertAfter(currentSplitter); - currentSplitter.settings.onDragStart(e); + currentSplitter.settings.onDragStart(e, currentSplitter); } }) @@ -309,7 +309,7 @@ } } $('.splitter_mask').remove(); - currentSplitter.settings.onDragEnd(e); + currentSplitter.settings.onDragEnd(e, currentSplitter); currentSplitter.removeClass('splitter-active'); currentSplitter = null; } @@ -341,7 +341,7 @@ currentSplitter.setPosition(position - currentSplitter.offset().top - currentSplitter.splitterSizeHalf); } e.preventDefault(); - currentSplitter.settings.onDrag(e); + currentSplitter.settings.onDrag(e, currentSplitter); } } );