Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tips "Reason" link opens new tab always #1236

Closed
zakhap opened this issue Jun 29, 2021 · 0 comments · Fixed by #1242
Closed

Tips "Reason" link opens new tab always #1236

zakhap opened this issue Jun 29, 2021 · 0 comments · Fixed by #1242
Assignees
@RakeshUP
Labels
1 1-2 hour task

Comments

@zakhap
Copy link
Collaborator

zakhap commented Jun 29, 2021 •
edited
Loading

Currently, every tip "reason" link opens to new tab. Example tip page here

If the link is to a thread/comment on commonwealth, we should just redirect there not open new tab.
If the link is external, open new tab.
@zakhap zakhap added the 1 1-2 hour task label Jun 29, 2021
@RakeshUP RakeshUP self-assigned this Jul 1, 2021
@RakeshUP RakeshUP mentioned this issue Jul 1, 2021
Merged
5 tasks
@zakhap zakhap linked a pull request Jul 3, 2021 that will close this issue
Tips "Reason" fix: Commonwealth links open in the same tab #1242
Merged
5 tasks
@zakhap zakhap closed this as completed Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RakeshUP RakeshUP

Labels
1 1-2 hour task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tips "Reason" fix: Commonwealth links open in the same tab hicommonwealth/commonwealth
3 participants
@zakhap @RakeshUP @maxwellfoley3