inconsistent NavLink matching

[hi-ogawa]

I thought this would be fixed by

• fix(react-server): decode dynamic route params vite-plugins#271

but, it looks like it has more things to consider (like react router PR has indicated the complexity already remix-run/react-router#9477).

For this page https://react-server-demo-remix-tutorial.hiro18181.workers.dev/contacts/kent%20c.-dodds, initial render misses NavLink highlight, but after client side navigation, it gets right.

Partly, the inconsistency is also coming from @tanstack/history's location.pathname, so it's worth investigating.

---

OK, so this line has pathname = /contacts/kent%20c.-dodds on initial render, but has /contacts/kent c.-dodds on client side navigation (i.e. history.push).

react-server-demo-remix-tutorial/src/routes/_client.tsx

Lines 5 to 6 in 970b2b3

	export function NavLink(props: React.ComponentProps<typeof Link>) {
	const pathname = useRouter((s) => s.location.pathname);

The same issue might repro on tanstack router?