Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: documentation #115

Closed
5 tasks done
ranocha opened this issue Nov 23, 2022 · 4 comments · Fixed by #118
Closed
5 tasks done

JOSS review: documentation #115

ranocha opened this issue Nov 23, 2022 · 4 comments · Fixed by #118

Comments

@ranocha
Copy link

ranocha commented Nov 23, 2022

  • I am not familier with Vlasiator. Thus, it would be nice for someone like me to include a basic tutorial how to obtain such simulation data (or at least link to a Vlasiator tutorial).
  • It would be great to get a basic introduction to the package already in the README.md, e.g., basic installation instructions and a simple use case.
  • It may be confusing that the URLs in the "About" section on GitHub and in the README.md point to the development documentation, not the latest stable release (which people will usually install).
  • It would be nice to add a link from the documentation to the repository (to make it easier for people to see the code when they find the documentation with a search engine). For example, the first sentence on https://henry2004y.github.io/Vlasiator.jl/stable could start with "Vlasiator.jl is a data processing and analyzing tool" instead of "Data processing and analyzing tool".
  • The gallery at https://henry2004y.github.io/Vlasiator.jl/stable/gallery/ is nice - but it lacks links to the source code used to generate the plots.

Xref openjournals/joss-reviews#4906

@henry2004y
Copy link
Owner

henry2004y commented Nov 23, 2022

Thanks for the review! I have one question regarding links to the plotting source codes: the data for generating some of the good-looking plots are either private or too large to put on a public server. How should I handle that in general? Are links to sample plotting scripts without data enough @ranocha?

@ranocha
Copy link
Author

ranocha commented Nov 23, 2022

Could you maybe provide some sample data you can use as a stub (also for testing)? You could have a high-resolution version in the gallery followed by a low-resolution version people can use to reproduce the visualizations.

@henry2004y henry2004y linked a pull request Nov 23, 2022 that will close this issue
@henry2004y henry2004y reopened this Nov 23, 2022
@henry2004y
Copy link
Owner

Currently the test data can be obtained from vlsv_data, which is mentioned in the Log Section of the documentation. These files are also used for testing. For potential Vlasiator.jl users, it is highly likely that they will first obtain some pre-existing data from private servers and then perform analysis with Vlasiator.jl. Hopefully these reference VLSV output data are enough for checking the validity of the software --- they may be changed in the future if we want higher coverage rate or new features are requested.

@ranocha
Copy link
Author

ranocha commented Nov 28, 2022

Sounds good to me. This issue can be closed once the software version in the paper is updated accordingly.

This was referenced Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants