-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS review: documentation #115
Comments
Thanks for the review! I have one question regarding links to the plotting source codes: the data for generating some of the good-looking plots are either private or too large to put on a public server. How should I handle that in general? Are links to sample plotting scripts without data enough @ranocha? |
Could you maybe provide some sample data you can use as a stub (also for testing)? You could have a high-resolution version in the gallery followed by a low-resolution version people can use to reproduce the visualizations. |
Currently the test data can be obtained from vlsv_data, which is mentioned in the Log Section of the documentation. These files are also used for testing. For potential Vlasiator.jl users, it is highly likely that they will first obtain some pre-existing data from private servers and then perform analysis with Vlasiator.jl. Hopefully these reference VLSV output data are enough for checking the validity of the software --- they may be changed in the future if we want higher coverage rate or new features are requested. |
Sounds good to me. This issue can be closed once the software version in the paper is updated accordingly. |
Xref openjournals/joss-reviews#4906
The text was updated successfully, but these errors were encountered: