Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get conversations by custom field #77

Closed
miken32 opened this issue Dec 21, 2018 · 6 comments
Closed

Can't get conversations by custom field #77

miken32 opened this issue Dec 21, 2018 · 6 comments
Assignees

Comments

@miken32
Copy link
Contributor

miken32 commented Dec 21, 2018

In the v2 code, there appears to be no way to filter conversations based on custom fields, as described in the API: https://developer.helpscout.com/mailbox-api/endpoints/conversations/list/#custom-fields-search

@davidstanley01
Copy link
Contributor

Aw, dang. I think you're right. I'll get to work on this next week after the holiday...

@davidstanley01
Copy link
Contributor

I ended up with some time and got to work. With so many out next week, we probably won't get this reviewed and/or merged until the week after that. Let me know if you need it sooner...

@miken32
Copy link
Contributor Author

miken32 commented Dec 22, 2018

Haha I just noticed a pull request and was thinking to myself "how could I miss that?" then realized it linked to this issue. No hurry, I can modify local code to match and will advise if we run into any problems with the new code.

@davidstanley01
Copy link
Contributor

I’ll merge that PR and tag a new version in the morning.

@davidstanley01
Copy link
Contributor

Fixed with #78. Closing issue.

@dacopavlov
Copy link

Hey guys,

Can someone give an example of how to get a conversation by email? I try many things but didn't succeed to get the result.

This is my last try and its not working:
$filter = (new CustomerFilters())
->withQuery('email:test@gmail.com');
$client = self::initHelpscout();
$customer = $client->customers()->list($filter);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants