Is allowed to have other files in the releases created by chart-releaser?

[jvanz]

This repository uses the chart-releaser to do the job of releasing all the 3 helm charts. After the release is created some additional files are added to the release. This is causing issues. In the next time that new changes are pushed to the repository, chart-releaser fails because it trys to open the additional files as Helm charts. This is makes the CI job to failed.

Is it fine to add more assets in the releases created by chart-releaser? If so, how can I tell the tool to ignore the files that are not charts?

If this is not supported, what do you think to add this feature? (I'm willing to work on that)

[mattfarina]

I think this is a bug in the way the index files are updated. Take a look at ....

chart-releaser/pkg/releaser/releaser.go

Lines 171 to 185 in 0eb1d31

	for _, asset := range release.Assets {
	downloadURL, _ := url.Parse(asset.URL)
	name := filepath.Base(downloadURL.Path)
	baseName := strings.TrimSuffix(name, filepath.Ext(name))
	tagParts := r.splitPackageNameAndVersion(baseName)
	packageName, packageVersion := tagParts[0], tagParts[1]
	fmt.Printf("Found %s-%s.tgz\n", packageName, packageVersion)
	if _, err := indexFile.Get(packageName, packageVersion); err != nil {
	if err := r.addToIndexFile(indexFile, downloadURL.String()); err != nil {
	return false, err
	}
	update = true
	break
	}
	}

In this code it assumes all files on the release are charts and does not check if they have a valid name or extension. I would suggest checking for that would be a valid fix.

[scottrigby]

I think you’re right Matt. Adding addtl files during CI to .cr-release-packages dir seems like a feature not a bug. We should't assume all assets on the release are charts 👌

[jvanz]

Cool, I'll work on this issue and open a PR with a fix for your review. :)