-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hangs when select and edit in a 15MB file. #7396
Comments
I try this by selecting only 100 lines and it works fine but still face the same issue if select the whole file even without Zellij on Alacrity and on the Ubuntu terminal too. |
I'm very certain there's already an issue for this, but I can't seem to find it through a quick search. Regardless, this is just a limitation of having a lot of active selections at once. |
I've worked with very large files (hundreds of Mb) and even if helix gets slow it does respond after a little while. Also, one way to speed this up is to yank the search text first: |
@CptPotato I have tried your first suggestion to escape the parenthesis, It still hangs for me when try to edit. |
Poeple seem to have missread the issue description: The problem is not the regex selection that is pretty fast but actually editing once there is a selection is insanely slow. I whipped up a quick flamegraph and now know why: Almost all time is spend updating the selection (ropey is so fast it doesn't even show up). The reason is simple: muiticursos edits currently have a time complexity |
Fixed in #7408 |
Summary
The file is 14.9 MB in size sample data
I try "% + s + Ok(" and it hangs
Reproduction Steps
I tried this:
hx 15mb_file_name
I expected this to happen:
I should be able to edit the text.
Instead, this happened:
It hangs and does not respond.
Helix log
Unable to get logs since it is not responding at all.
Platform
Linux (Ubuntu 23.04)
Terminal Emulator
alacrity + zellij
Helix Version
master
The text was updated successfully, but these errors were encountered: