Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript code actions not working with eslint #4191

Closed
cd-a opened this issue Oct 11, 2022 · 3 comments
Closed

TypeScript code actions not working with eslint #4191

cd-a opened this issue Oct 11, 2022 · 3 comments

Comments

@cd-a
Copy link
Contributor

cd-a commented Oct 11, 2022

I see the PR was merged to have code actions on missing imports, and that works fine.

However, there are a lot of other places where code actions are useful, and necessary.

Let's say we have an effect and a missing dependency. Now, the eslint rule react-hooks/exhaustive-deps that is set up in the project makes sure those are checked.

Here is neovim acting on that missing dependency, both marking the error and showing proper code actions:
CleanShot 2022-10-11 at 07 57 18@2x

Helix doesn't see any error and says no code action available:
CleanShot 2022-10-11 at 07 58 29@2x

@archseer
Copy link
Member

Can you provide more details? Are you using the latest master? Is there a difference in the LSP client initialization or are we missing a certain code action category in our client init? Dumping a trace of LSP traffic in your neovim setup vs helix setup would help.

@cd-a
Copy link
Contributor Author

cd-a commented Oct 11, 2022

I'm using latest master, and not using any custom init code on helix for the LSP.

It seems any rule from eslint is not picked up, so it seems it's the eslint issue and not the LSP.

#3231 and #1396 seem to be related to that, just found it.

@cd-a
Copy link
Contributor Author

cd-a commented Oct 19, 2022

Closing as tested with #2507 it works!

@cd-a cd-a closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants