Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change question whether to make mappings project-independent to a confirmation #510

Closed
helgoboss opened this issue Dec 24, 2021 · 5 comments
Labels
enhancement New feature or request realearn Related to ReaLearn
Milestone

Comments

@helgoboss
Copy link
Owner

Reasoning: https://forum.cockos.com/showpost.php?p=2508953&postcount=1845

@vonglan
Copy link

vonglan commented Dec 27, 2021

We had a discussion about this in #353 .
It seems that for different use cases, different addressing defaults for FX parameter targets are useful:

  • for ad hoc mappings, created spontaneously and not saved as presets, "by Id" (the current default after "learn") is best, so the relation to the FX is "sticky" when the FX is renamed, moved etc.
  • for people using "Auto-load: Depending on focused FX", "focused FX" is perfect
  • some folks might prefer "FX by name" as default (e.g. here Add "Auto-load preset" option "Depending on currently active FX" #188 (comment): "in all my scenario I would always want to control different parameters of different plugins in the chain")

Because "focused" is not the only useful default, I am not sure whether just changing the popup to a confirmation is good.

Maybe make it dependent on whether "Auto-load" is used for the preset or not? If it is not used, make "FX by name" the default (after confirmation of the popup)?

(#228 is also related , a more complex and more powerful feature.)

@helgoboss
Copy link
Owner Author

Yes. This deserves some more attention. But I'm not sure how to do it without requiring too much user interaction. It's not possible to automatically detect whether "Auto-load" is going to be used for a preset or not. That's like predicting future :)

@vonglan
Copy link

vonglan commented Dec 29, 2021

Offer a choice of three in the popup? (Keep, Change to "focused FX", Change to "by name"). Or move the whole topic from popup to right-click menu? (Maybe let the popup show a warning that needs to be confirmed once.)

Changing to "focused FX" can always be done (requires less information), changing from "focused FX" to "by name" requires human intelligence.

@vonglan
Copy link

vonglan commented Apr 8, 2022

Just noticed, #252 is also about the same topic.
You suggested Track FX as a solution:

a new FX selector "Instance FX" and track selector "Instance track" and a way to set an FX / a track for the whole ReaLearn instance (which can be anything: Focused FX, By name, etc.).

@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
@helgoboss
Copy link
Owner Author

Or move the whole topic from popup to right-click menu? (Maybe let the popup show a warning that needs to be confirmed once.)

This is a good idea. I implemented it like this in #252.

@helgoboss helgoboss added this to the 2.16.2 milestone Aug 14, 2024
@helgoboss helgoboss moved this to In Progress in Helgobox Development Aug 14, 2024
@helgoboss helgoboss moved this from In Progress to Done in Helgobox Development Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request realearn Related to ReaLearn
Projects
Archived in project
Development

No branches or pull requests

2 participants