From 4031779105c299e0f92f18d3e37e51f3abe55902 Mon Sep 17 00:00:00 2001 From: Joshua Scott Date: Tue, 7 Mar 2017 09:25:40 -0600 Subject: [PATCH] Clean up elixir 1.4 compile warnings (#65) * Clean up elixir 1.4 compile warnings * Fix a couple more deprecation warnings --- lib/hedwig/adapter.ex | 10 ++++------ lib/hedwig/adapters/test.ex | 2 +- lib/mix/tasks/hedwig.gen.robot.ex | 8 ++++---- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/lib/hedwig/adapter.ex b/lib/hedwig/adapter.ex index 32ec0c5..aa771ab 100644 --- a/lib/hedwig/adapter.ex +++ b/lib/hedwig/adapter.ex @@ -7,8 +7,6 @@ defmodule Hedwig.Adapter do `Hedwig.Message` struct and call `Hedwig.Robot.handle_message(robot, msg)`. """ - use Behaviour - @doc false defmacro __using__(_opts) do quote do @@ -57,7 +55,7 @@ defmodule Hedwig.Adapter do @doc false def start_link(module, opts) do - GenServer.start_link(module, {self, opts}) + GenServer.start_link(module, {self(), opts}) end @type robot :: pid @@ -65,7 +63,7 @@ defmodule Hedwig.Adapter do @type opts :: any @type msg :: Hedwig.Message.t - defcallback send(pid, msg) :: term - defcallback reply(pid, msg) :: term - defcallback emote(pid, msg) :: term + @callback send(pid, msg) :: term + @callback reply(pid, msg) :: term + @callback emote(pid, msg) :: term end diff --git a/lib/hedwig/adapters/test.ex b/lib/hedwig/adapters/test.ex index d8fd504..e51b87a 100644 --- a/lib/hedwig/adapters/test.ex +++ b/lib/hedwig/adapters/test.ex @@ -4,7 +4,7 @@ defmodule Hedwig.Adapters.Test do use Hedwig.Adapter def init({robot, opts}) do - GenServer.cast(self, :after_init) + GenServer.cast(self(), :after_init) {:ok, %{conn: nil, opts: opts, robot: robot}} end diff --git a/lib/mix/tasks/hedwig.gen.robot.ex b/lib/mix/tasks/hedwig.gen.robot.ex index 17d4bc7..5b21426 100644 --- a/lib/mix/tasks/hedwig.gen.robot.ex +++ b/lib/mix/tasks/hedwig.gen.robot.ex @@ -45,11 +45,11 @@ defmodule Mix.Tasks.Hedwig.Gen.Robot do """] aka = opts[:aka] || "/" - name = opts[:name] || prompt_for_name + name = opts[:name] || prompt_for_name() robot = opts[:robot] || default_robot(app) adapter = get_adapter_module(deps) - underscored = Mix.Utils.underscore(robot) + underscored = Macro.underscore(robot) file = Path.join("lib", underscored) <> ".ex" robot = Module.concat([robot]) @@ -79,7 +79,7 @@ defmodule Mix.Tasks.Hedwig.Gen.Robot do defp default_robot(app) do case Application.get_env(app, :app_namespace, app) do - ^app -> app |> to_string |> Mix.Utils.camelize + ^app -> app |> to_string |> Macro.camelize mod -> mod |> inspect end |> Module.concat(Robot) end @@ -87,7 +87,7 @@ defmodule Mix.Tasks.Hedwig.Gen.Robot do defp available_adapters(deps) do deps |> all_modules - |> Kernel.++(hedwig_modules) + |> Kernel.++(hedwig_modules()) |> Enum.uniq |> Enum.filter(&implements_adapter?/1) |> Enum.with_index